Skip to content

[PW_SID:1148877] iio: dac: Add support for AD5529R DAC - #2505

Closed
linux-riscv-bot wants to merge 6 commits into
workflow__riscv__fixesfrom
pw1148877
Closed

[PW_SID:1148877] iio: dac: Add support for AD5529R DAC#2505
linux-riscv-bot wants to merge 6 commits into
workflow__riscv__fixesfrom
pw1148877

Conversation

@linux-riscv-bot

@linux-riscv-bot linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown

PR for series 1148877 applied to workflow__riscv__fixes

Name: iio: dac: Add support for AD5529R DAC
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1148877
Version: 9

ThreeBottleCap and others added 6 commits August 14, 2026 14:12
@ThreeBottleCap Paul Walmsley
riscv: mm: make EXECMEM_KPROBES writable without CONFIG_STRICT_MODULE…
784f45c 
…_RWX

When CONFIG_STRICT_MODULE_RWX is not set, execmem cannot create
temporary writable mappings for read-only executable pages. In this
case, the execmem ranges must already have writable permissions.

Currently EXECMEM_KPROBES unconditionally uses PAGE_KERNEL_READ_EXEC,
which causes kprobe instruction slot writes to trigger page faults
on systems where CONFIG_STRICT_MODULE_RWX is not enabled.

Fix this by using PAGE_KERNEL_EXEC when CONFIG_STRICT_MODULE_RWX
is not available.

Signed-off-by: Xiaofeng Yuan <xiaofengmian@163.com>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Nam Cao <namcao@linutronix.de>
Link: https://patch.msgid.link/20260814082742.148403-2-xiaofengmian@163.com
Signed-off-by: Paul Walmsley <pjw@kernel.org>
@ThreeBottleCap Paul Walmsley
riscv: patch: skip fixmap mapping when kernel text is already writable
8d9d4fd 
patch_map() always creates a temporary writable mapping via fixmap for
kernel text addresses, even when CONFIG_STRICT_KERNEL_RWX is disabled
and the kernel text is already mapped with _PAGE_WRITE.

This is unnecessary overhead at best, and on minimal configurations
it can cause page faults.

Skip the fixmap path for kernel text when CONFIG_STRICT_KERNEL_RWX
is not enabled, since the text pages are already writable in that case.
The module text path is already gated on CONFIG_STRICT_MODULE_RWX and
is kept unchanged.

Reported-by: Klara Modin <klara@kasm.eu>
Closes: https://lore.kernel.org/all/ant_8TaBbov_GS4i@soda.int.kasm.eu/
Reported-by: Lad Prabhakar <prabhakar.csengg@gmail.com>
Closes: https://lore.kernel.org/all/CA+V-a8tQK8rih9SGGTyqrEBGpNkx4H0eX2YccCRrgkVAPr+EBg@mail.gmail.com/
Tested-by: Klara Modin <klarasmodin@gmail.com>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://patch.msgid.link/20260814082742.148403-3-xiaofengmian@163.com
Signed-off-by: Paul Walmsley <pjw@kernel.org>
Linux RISC-V bot
Adding CI files
492cc66
@jansunil Linux RISC-V bot
spi: dt-bindings: Add spi-device-addr peripheral property
7acdc7c 
Some SPI devices support sharing a single chip select across multiple
physical chips by encoding a device address in the SPI frame itself.
Add the generic spi-device-addr property for describing these hardware
addresses. The property is placed on the SPI peripheral node and may
contain multiple addresses.

Acked-by: Nuno Sá <nuno.sa@analog.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Signed-off-by: Janani Sunil <janani.sunil@analog.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@jansunil Linux RISC-V bot
dt-bindings: iio: dac: Add AD5529R
6ca3056 
Devicetree bindings for AD5529R 16 channel 12/16 bit high voltage,
buffered voltage output digital-to-analog converter (DAC) with an
integrated precision reference.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Janani Sunil <janani.sunil@analog.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@jansunil Linux RISC-V bot
iio: dac: Add AD5529R DAC driver support
9eb2184 
Add support for AD5529R 16-channel, 12/16 bit Digital to Analog Converter
from Analog Devices.

The device communicates over SPI and supports per-channel output range
configuration. An optional external 4.096V reference can be used in
place of the internal reference.

Signed-off-by: Janani Sunil <janani.sunil@analog.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v9,1/3] spi: dt-bindings: Add spi-device-addr peripheral property"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 144.48 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v9,1/3] spi: dt-bindings: Add spi-device-addr peripheral property"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1157.43 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v9,1/3] spi: dt-bindings: Add spi-device-addr peripheral property"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1412.01 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v9,1/3] spi: dt-bindings: Add spi-device-addr peripheral property"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.98 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v9,1/3] spi: dt-bindings: Add spi-device-addr peripheral property"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.27 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v9,1/3] spi: dt-bindings: Add spi-device-addr peripheral property"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.74 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v9,1/3] spi: dt-bindings: Add spi-device-addr peripheral property"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 88.55 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v9,1/3] spi: dt-bindings: Add spi-device-addr peripheral property"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v9,1/3] spi: dt-bindings: Add spi-device-addr peripheral property"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v9,1/3] spi: dt-bindings: Add spi-device-addr peripheral property"
module-param
Desc: Detect module_param changes
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v9,1/3] spi: dt-bindings: Add spi-device-addr peripheral property"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v9,1/3] spi: dt-bindings: Add spi-device-addr peripheral property"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.32 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v9,2/3] dt-bindings: iio: dac: Add AD5529R"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 144.42 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v9,2/3] dt-bindings: iio: dac: Add AD5529R"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1118.83 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v9,2/3] dt-bindings: iio: dac: Add AD5529R"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1414.75 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v9,2/3] dt-bindings: iio: dac: Add AD5529R"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 27.27 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v9,2/3] dt-bindings: iio: dac: Add AD5529R"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.03 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v9,2/3] dt-bindings: iio: dac: Add AD5529R"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.13 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v9,2/3] dt-bindings: iio: dac: Add AD5529R"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 89.12 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v9,2/3] dt-bindings: iio: dac: Add AD5529R"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v9,2/3] dt-bindings: iio: dac: Add AD5529R"
kdoc
Desc: Detects for kdoc errors
Duration: 0.95 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v9,2/3] dt-bindings: iio: dac: Add AD5529R"
module-param
Desc: Detect module_param changes
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v9,2/3] dt-bindings: iio: dac: Add AD5529R"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v9,2/3] dt-bindings: iio: dac: Add AD5529R"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v9,3/3] iio: dac: Add AD5529R DAC driver support"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 143.68 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v9,3/3] iio: dac: Add AD5529R DAC driver support"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1147.84 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v9,3/3] iio: dac: Add AD5529R DAC driver support"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1464.39 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v9,3/3] iio: dac: Add AD5529R DAC driver support"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.55 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v9,3/3] iio: dac: Add AD5529R DAC driver support"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.11 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v9,3/3] iio: dac: Add AD5529R DAC driver support"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 410.79 seconds
Result: WARNING
Output:

WARNING: struct regmap_config should normally be const
#476: FILE: drivers/iio/dac/ad5529r.c:397:
+	struct regmap_config regmap_8bit_cfg;

WARNING: struct regmap_config should normally be const
#477: FILE: drivers/iio/dac/ad5529r.c:398:
+	struct regmap_config regmap_16bit_cfg;

WARNING: struct regmap_config should normally be const
#502: FILE: drivers/iio/dac/ad5529r.c:423:
+	regmap_8bit_cfg = (struct regmap_config) {

WARNING: struct regmap_config should normally be const
#512: FILE: drivers/iio/dac/ad5529r.c:433:
+	regmap_16bit_cfg = (struct regmap_config) {

total: 0 errors, 4 warnings, 0 checks, 574 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 9eb2184f4f97 ("iio: dac: Add AD5529R DAC driver support") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 4 warnings, 0 checks, 574 lines checked
WARNING: struct regmap_config should normally be const

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v9,3/3] iio: dac: Add AD5529R DAC driver support"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 87.60 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v9,3/3] iio: dac: Add AD5529R DAC driver support"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v9,3/3] iio: dac: Add AD5529R DAC driver support"
kdoc
Desc: Detects for kdoc errors
Duration: 1.01 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v9,3/3] iio: dac: Add AD5529R DAC driver support"
module-param
Desc: Detect module_param changes
Duration: 0.32 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v9,3/3] iio: dac: Add AD5529R DAC driver support"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v9,3/3] iio: dac: Add AD5529R DAC driver support"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.32 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot force-pushed the workflow__riscv__fixes branch 2 times, most recently from bb1a926 to 6f6f7c0 Compare August 21, 2026 03:35
@linux-riscv-bot
linux-riscv-bot deleted the pw1148877 branch August 27, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linux-riscv-bot @ThreeBottleCap @jansunil