Skip to content

[PW_SID:1150311] perf: riscv: Fix counter_idx_base in PMU snapshot restart - #2514

Closed
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1150311
Closed

[PW_SID:1150311] perf: riscv: Fix counter_idx_base in PMU snapshot restart#2514
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw1150311

Conversation

@linux-riscv-bot

Copy link
Copy Markdown

PR for series 1150311 applied to workflow__riscv__fixes

Name: perf: riscv: Fix counter_idx_base in PMU snapshot restart
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1150311
Version: 1

In pmu_sbi_start_ovf_ctrs_snapshot(), after for_each_set_bit() finishes
iterating used_hw_ctrs[i], idx is left at BITS_PER_LONG. The subsequent
sbi_ecall() uses idx * BITS_PER_LONG as counter_idx_base, passing an
out-of-range value (4096 on 64-bit) to SBI_EXT_PMU_COUNTER_START.

This causes the firmware to reject the call and overflowed counters are
never restarted.

Use the outer loop index 'i' instead of the exhausted iterator 'idx'.

Fixes: a862521 ("drivers/perf: riscv: Implement SBI PMU snapshot function")
Signed-off-by: liutong <liutong@iscas.ac.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "perf: riscv: Fix counter_idx_base in PMU snapshot restart"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 147.03 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "perf: riscv: Fix counter_idx_base in PMU snapshot restart"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1461.52 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "perf: riscv: Fix counter_idx_base in PMU snapshot restart"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1773.35 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "perf: riscv: Fix counter_idx_base in PMU snapshot restart"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 28.74 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "perf: riscv: Fix counter_idx_base in PMU snapshot restart"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 30.30 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "perf: riscv: Fix counter_idx_base in PMU snapshot restart"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.78 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "perf: riscv: Fix counter_idx_base in PMU snapshot restart"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 89.17 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "perf: riscv: Fix counter_idx_base in PMU snapshot restart"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "perf: riscv: Fix counter_idx_base in PMU snapshot restart"
kdoc
Desc: Detects for kdoc errors
Duration: 1.25 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "perf: riscv: Fix counter_idx_base in PMU snapshot restart"
module-param
Desc: Detect module_param changes
Duration: 0.62 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "perf: riscv: Fix counter_idx_base in PMU snapshot restart"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "perf: riscv: Fix counter_idx_base in PMU snapshot restart"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot deleted the pw1150311 branch August 31, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants