[PW_SID:1154144] mm: Drop pxd_ERROR() - #2556
Conversation
Move ptval_to_str() inside a header thus making the helper more generally available for new users which are being added later. While here, also move another related string size macro PTVAL_STR_MAX inside the header as well. Cc: Andrew Morton <akpm@linux-foundation.org> Cc: David Hildenbrand <david@kernel.org> Cc: Lorenzo Stoakes <ljs@kernel.org> Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Acked-by: David Hildenbrand (Arm) <david@kernel.org> Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
pxd_ERROR() has been used in generic mm just to print the page table entry in pxd_clear_bad() before clearing those out with pxd_clear() later. These pxd_ERROR() macros have been provided by all platforms which basically did the same thing. Make pxd_clear_bad() use recently added ptval_to_str() instead for printing page table entries thus completely dropping dependency on platform provided pxd_ERROR() macros which can then be dropped off later on. Cc: Andrew Morton <akpm@linux-foundation.org> Cc: David Hildenbrand <david@kernel.org> Cc: Lorenzo Stoakes <ljs@kernel.org> Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Acked-by: David Hildenbrand (Arm) <david@kernel.org> Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Directly use pr_err() in __set_fixmap() and drop pte_ERROR() which helps in eventually dropping pte_ERROR() macro across the tree. In this new printing __FILE__ and __LINE__ has been dropped because they are always the same and don't really add any value. The new ptval_to_str() helper is being used for converting pgtable entry value into a string. The error message itself has been cleaned up as well. Cc: Huacai Chen <chenhuacai@kernel.org> Cc: WANG Xuerui <kernel@xen0n.name> Cc: loongarch@lists.linux.dev Cc: linux-kernel@vger.kernel.org Acked-by: David Hildenbrand (Arm) <david@kernel.org> Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Drop [pmd|pgd]_ERROR() followed by [pmd|pgd]_clear() instances. But instead directly use semantically equivalent generic helpers [pmd|pgd]_clear_bad() in unmap_uncached_[pte|pmd]() which helps in dropping their corresponding [pmd|pgd]_ERROR() macros across the tree. Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com> Cc: Helge Deller <deller@gmx.de> Cc: linux-parisc@vger.kernel.org Cc: linux-kernel@vger.kernel.org Reviewed-by: David Hildenbrand (Arm) <david@kernel.org> Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Directly use pr_err() in set_pte_phys() and drop pte_ERROR() which helps in eventually dropping pte_ERROR() macro across the tree. In this new printing __FILE__ and __LINE__ has been dropped because they are always the same and don't really add any value. Besides ptrval_to_str() has been able to handle different PTE representation with and without CONFIG_X2TLB, which helped in unifying error message printing. Cc: Yoshinori Sato <ysato@users.sourceforge.jp> Cc: Rich Felker <dalias@libc.org> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Cc: linux-sh@vger.kernel.org Cc: linux-kernel@vger.kernel.org Acked-by: David Hildenbrand (Arm) <david@kernel.org> Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Stop using [p4d|pud|pmd]_ERROR() in __get_pte_phys() as the pgtable entries are known to be NULL and hence could not really be accessed. Cc: Yoshinori Sato <ysato@users.sourceforge.jp> Cc: Rich Felker <dalias@libc.org> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Cc: linux-sh@vger.kernel.org Cc: linux-kernel@vger.kernel.org Reviewed-by: David Hildenbrand (Arm) <david@kernel.org> Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Stop using pgd_ERROR() in __get_pte_phys() when page table entry is already known to be empty. Cc: Yoshinori Sato <ysato@users.sourceforge.jp> Cc: Rich Felker <dalias@libc.org> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Cc: linux-sh@vger.kernel.org Cc: linux-kernel@vger.kernel.org Reviewed-by: David Hildenbrand (Arm) <david@kernel.org> Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
There are no more users left for any pxd_ERROR() either in generic MM or in the platform MM. Hence all these platform macros along with their generic fallback could be dropped across the tree. Cc: linux-alpha@vger.kernel.org Cc: linux-snps-arc@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-csky@vger.kernel.org Cc: linux-hexagon@vger.kernel.org Cc: loongarch@lists.linux.dev Cc: linux-m68k@lists.linux-m68k.org Cc: linux-mips@vger.kernel.org Cc: linux-openrisc@vger.kernel.org Cc: linux-parisc@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-riscv@lists.infradead.org Cc: linux-s390@vger.kernel.org Cc: linux-sh@vger.kernel.org Cc: sparclinux@vger.kernel.org Cc: linux-um@lists.infradead.org Cc: linux-arch@vger.kernel.org Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> # m68k Acked-by: David Hildenbrand (Arm) <david@kernel.org> Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
|
Patch 1: "[1/8] mm: Make ptval_to_str() generally available" |
|
Patch 1: "[1/8] mm: Make ptval_to_str() generally available" |
|
Patch 1: "[1/8] mm: Make ptval_to_str() generally available" |
|
Patch 1: "[1/8] mm: Make ptval_to_str() generally available" |
|
Patch 1: "[1/8] mm: Make ptval_to_str() generally available" |
|
Patch 1: "[1/8] mm: Make ptval_to_str() generally available" |
|
Patch 1: "[1/8] mm: Make ptval_to_str() generally available" |
|
Patch 1: "[1/8] mm: Make ptval_to_str() generally available" |
|
Patch 1: "[1/8] mm: Make ptval_to_str() generally available" |
|
Patch 1: "[1/8] mm: Make ptval_to_str() generally available" |
|
Patch 1: "[1/8] mm: Make ptval_to_str() generally available" |
|
Patch 1: "[1/8] mm: Make ptval_to_str() generally available" |
|
Patch 2: "[2/8] mm: Stop using pxd_ERROR()" |
|
Patch 2: "[2/8] mm: Stop using pxd_ERROR()" |
|
Patch 2: "[2/8] mm: Stop using pxd_ERROR()" |
|
Patch 2: "[2/8] mm: Stop using pxd_ERROR()" |
|
Patch 2: "[2/8] mm: Stop using pxd_ERROR()" |
|
Patch 2: "[2/8] mm: Stop using pxd_ERROR()" |
|
Patch 2: "[2/8] mm: Stop using pxd_ERROR()" |
|
Patch 2: "[2/8] mm: Stop using pxd_ERROR()" |
|
Patch 2: "[2/8] mm: Stop using pxd_ERROR()" |
|
Patch 8: "[8/8] mm: Drop pxd_ERROR()" |
|
Patch 8: "[8/8] mm: Drop pxd_ERROR()" |
|
Patch 8: "[8/8] mm: Drop pxd_ERROR()" |
|
Patch 8: "[8/8] mm: Drop pxd_ERROR()" |
|
Patch 8: "[8/8] mm: Drop pxd_ERROR()" |
|
Patch 8: "[8/8] mm: Drop pxd_ERROR()" |
|
Patch 8: "[8/8] mm: Drop pxd_ERROR()" |
|
Patch 8: "[8/8] mm: Drop pxd_ERROR()" |
|
Patch 8: "[8/8] mm: Drop pxd_ERROR()" |
|
Patch 8: "[8/8] mm: Drop pxd_ERROR()" |
|
Patch 8: "[8/8] mm: Drop pxd_ERROR()" |
|
Patch 8: "[8/8] mm: Drop pxd_ERROR()" |
f31bd45 to
667760c
Compare
PR for series 1154144 applied to workflow
Name: mm: Drop pxd_ERROR()
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1154144
Version: 1