Skip to content

[PW_SID:1154419] pinctrl: mpfs-mssio: three fixes - #2557

Closed
linux-riscv-bot wants to merge 10 commits into
workflow__riscv__fixesfrom
pw1154419
Closed

[PW_SID:1154419] pinctrl: mpfs-mssio: three fixes#2557
linux-riscv-bot wants to merge 10 commits into
workflow__riscv__fixesfrom
pw1154419

Conversation

@linux-riscv-bot

@linux-riscv-bot linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown

PR for series 1154419 applied to workflow__riscv__fixes

Name: pinctrl: mpfs-mssio: three fixes
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1154419
Version: 1

ThreeBottleCap and others added 10 commits August 20, 2026 17:56
@ThreeBottleCap Paul Walmsley
riscv: mm: make EXECMEM_KPROBES writable without CONFIG_STRICT_MODULE…
bacc5c9 
…_RWX

When CONFIG_STRICT_MODULE_RWX is not set, execmem cannot create
temporary writable mappings for read-only executable pages. In this
case, the execmem ranges must already have writable permissions.

Currently EXECMEM_KPROBES unconditionally uses PAGE_KERNEL_READ_EXEC,
which causes kprobe instruction slot writes to trigger page faults
on systems where CONFIG_STRICT_MODULE_RWX is not enabled.

Fix this by using PAGE_KERNEL_EXEC when CONFIG_STRICT_MODULE_RWX
is not available.

Signed-off-by: Xiaofeng Yuan <xiaofengmian@163.com>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Nam Cao <namcao@linutronix.de>
Link: https://patch.msgid.link/20260814082742.148403-2-xiaofengmian@163.com
Signed-off-by: Paul Walmsley <pjw@kernel.org>
@ThreeBottleCap Paul Walmsley
riscv: patch: skip fixmap mapping when kernel text is already writable
3c98c44 
patch_map() always creates a temporary writable mapping via fixmap for
kernel text addresses, even when CONFIG_STRICT_KERNEL_RWX is disabled
and the kernel text is already mapped with _PAGE_WRITE.

This is unnecessary overhead at best, and on minimal configurations
it can cause page faults.

Skip the fixmap path for kernel text when CONFIG_STRICT_KERNEL_RWX
is not enabled, since the text pages are already writable in that case.
The module text path is already gated on CONFIG_STRICT_MODULE_RWX and
is kept unchanged.

Reported-by: Klara Modin <klara@kasm.eu>
Closes: https://lore.kernel.org/all/ant_8TaBbov_GS4i@soda.int.kasm.eu/
Reported-by: Lad Prabhakar <prabhakar.csengg@gmail.com>
Closes: https://lore.kernel.org/all/CA+V-a8tQK8rih9SGGTyqrEBGpNkx4H0eX2YccCRrgkVAPr+EBg@mail.gmail.com/
Tested-by: Klara Modin <klarasmodin@gmail.com>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://patch.msgid.link/20260814082742.148403-3-xiaofengmian@163.com
Signed-off-by: Paul Walmsley <pjw@kernel.org>
@SiFiveHolland Paul Walmsley
Revert "riscv: Reset pmm when PR_TAGGED_ADDR_ENABLE is not set"
e2715cc 
This reverts commit 3033b2b.

The reverted patch is userspace-visible behavior change, not a bug fix.
The two variables here (pmm and pmlen) control two independent features:
pmm is the _hardware_ pointer masking mode that applies while executing
in userspace. pmlen is the shift amount that the _kernel_ uses when
untagging addresses; PMLEN_0 means no untagging occurs, so the kernel
does not accept tagged addresses in syscall arguments.

It is valid (as documented and tested by the self test) to enable
pointer masking without enabling the tagged address ABI. This separation
is necessary to allow userspace to create an execution environment
similar to what the kernel supports on arm64 by default, where TBI is
enabled but the tagged address ABI is not. (On arm64, there is no
equivalent to PR_PMLEN_MASK because TBI is always enabled.)

Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
Link: https://patch.msgid.link/20260820014551.1979772-1-samuel.holland@sifive.com
Cc: stable@vger.kernel.org
Fixes: 3033b2b ("riscv: Reset pmm when PR_TAGGED_ADDR_ENABLE is not set")
Signed-off-by: Paul Walmsley <pjw@kernel.org>
@dmantipov Paul Walmsley
riscv: use string helper in setup_global_riscv_enable()
5d8b569 
Prefer the convenient string choice 'str_disabled_enabled()'
helper over hardcoded strings in 'setup_global_riscv_enable()'.

Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Link: https://patch.msgid.link/20260819160546.3219942-1-dmantipov@yandex.ru
Signed-off-by: Paul Walmsley <pjw@kernel.org>
@tchiu-TT Paul Walmsley
riscv: hwprobe: initialize pair->value in hwprobe_one_pair()
2b05c32 
The vendor-extension handlers reached from hwprobe_one_pair()
(hwprobe_isa_vendor_ext_thead_0() and friends) only OR the present bits
into pair->value via VENDOR_EXTENSION_SUPPORTED() and clear their own
missing bits; they assume the caller has already zeroed pair->value.

That holds for hwprobe_get_values() (it zeroes each pair) and
hwprobe_get_cpus() (it re-initializes its scratch pair per key), but not
for complete_hwprobe_vdso_data(), which reuses a single pair across all
keys without re-zeroing. A vendor key therefore inherits stale bits from
the previously probed key, and the wrong value is cached in the vDSO
all_cpu_hwprobe_values[] and handed to userspace on the fast patih.

Zero pair->value once at the top of hwprobe_one_pair() so every handler
starts from a clean value regardless of the caller, and drop the now
redundant zeroing in the *_BLOCK_SIZE cases. hwprobe_isa_ext0() keeps its
own zeroing because hwprobe_ext0_has() calls it directly, bypassing
hwprobe_one_pair().

Fixes: a5ea53d ("riscv: hwprobe: Add thead vendor extension probing")
Signed-off-by: Andy Chiu <tchiu@tenstorrent.com>
Reviewed-by: Jesse Taube <jtaubepe@redhat.com>
Link: https://patch.msgid.link/20260725001614.2578617-2-tchiu@tenstorrent.com
Cc: stable@vger.kernel.org
Signed-off-by: Paul Walmsley <pjw@kernel.org>
@xhackerustc Paul Walmsley
riscv: bug: Make RV32 use GENERIC_BUG_RELATIVE_POINTERS
2c1efc4 
x86 did this in commit b0a848f ("x86/bugs: Make i386 use
GENERIC_BUG_RELATIVE_POINTERS")

powerpc did this in commit 1baa1f7 ("powerpc: Allow relative
pointers in bug table entries")

Similar as x86 and powerpc does, make RV32 use
GENERIC_BUG_RELATIVE_POINTERS for "there is only one code path." and
"less #ifdef is more better".

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Link: https://patch.msgid.link/20260221024255.3552-1-jszhang@kernel.org
Signed-off-by: Paul Walmsley <pjw@kernel.org>
Linux RISC-V bot
Adding CI files
6f6f7c0
@ConchuOD Linux RISC-V bot
pinctrl: mpfs-mssio: fix whitespace in debugfs output
fac6e6e 
The printout from mpfs_pinctrl_pinconf_dbg_show() is appended to
information from the core, so a leading space is required or the world
will end.

Fixes: 488d704 ("pinctrl: add polarfire soc mssio pinctrl driver")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@ConchuOD Linux RISC-V bot
pinctrl: mpfs-mssio: fix width of unused bank voltage setting
f3aff25 
The bank voltages are only 4 bits wide, so when a pin was unused the
driver was not correctly interpreting it as being at zero volts, because
the driver's value for unused had two extra set bits.

CC: stable@vger.kernel.org
Fixes: 488d704 ("pinctrl: add polarfire soc mssio pinctrl driver")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@ConchuOD Linux RISC-V bot
pinctrl: mpfs-mssio: use correct regmap function to set bank voltage
e43f9b0 
regmap_assign_bits() is not the correct function to use for an RMW
operation, as it maps to regmap_set_bits() or regmap_clear_bits() and
the former will never zero a bit. Use regmap_update_bits() instead,
which will actually set the bank voltages to what have been requested.

CC: stable@vger.kernel.org
Fixes: 488d704 ("pinctrl: add polarfire soc mssio pinctrl driver")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v1,1/3] pinctrl: mpfs-mssio: fix whitespace in debugfs output"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 145.93 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v1,1/3] pinctrl: mpfs-mssio: fix whitespace in debugfs output"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1422.39 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v1,1/3] pinctrl: mpfs-mssio: fix whitespace in debugfs output"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1765.80 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v1,1/3] pinctrl: mpfs-mssio: fix whitespace in debugfs output"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 28.96 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v1,1/3] pinctrl: mpfs-mssio: fix whitespace in debugfs output"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 30.23 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v1,1/3] pinctrl: mpfs-mssio: fix whitespace in debugfs output"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.80 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v1,1/3] pinctrl: mpfs-mssio: fix whitespace in debugfs output"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 89.70 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v1,1/3] pinctrl: mpfs-mssio: fix whitespace in debugfs output"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v1,1/3] pinctrl: mpfs-mssio: fix whitespace in debugfs output"
kdoc
Desc: Detects for kdoc errors
Duration: 0.94 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v1,1/3] pinctrl: mpfs-mssio: fix whitespace in debugfs output"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v1,1/3] pinctrl: mpfs-mssio: fix whitespace in debugfs output"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 1: "[v1,1/3] pinctrl: mpfs-mssio: fix whitespace in debugfs output"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.33 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v1,2/3] pinctrl: mpfs-mssio: fix width of unused bank voltage setting"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 146.42 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v1,2/3] pinctrl: mpfs-mssio: fix width of unused bank voltage setting"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1431.78 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v1,2/3] pinctrl: mpfs-mssio: fix width of unused bank voltage setting"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1768.15 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v1,2/3] pinctrl: mpfs-mssio: fix width of unused bank voltage setting"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 28.56 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v1,2/3] pinctrl: mpfs-mssio: fix width of unused bank voltage setting"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 30.29 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v1,2/3] pinctrl: mpfs-mssio: fix width of unused bank voltage setting"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.79 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v1,2/3] pinctrl: mpfs-mssio: fix width of unused bank voltage setting"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 90.89 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v1,2/3] pinctrl: mpfs-mssio: fix width of unused bank voltage setting"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v1,2/3] pinctrl: mpfs-mssio: fix width of unused bank voltage setting"
kdoc
Desc: Detects for kdoc errors
Duration: 0.85 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v1,2/3] pinctrl: mpfs-mssio: fix width of unused bank voltage setting"
module-param
Desc: Detect module_param changes
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v1,2/3] pinctrl: mpfs-mssio: fix width of unused bank voltage setting"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 2: "[v1,2/3] pinctrl: mpfs-mssio: fix width of unused bank voltage setting"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.32 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v1,3/3] pinctrl: mpfs-mssio: use correct regmap function to set bank voltage"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 146.15 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v1,3/3] pinctrl: mpfs-mssio: use correct regmap function to set bank voltage"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1425.31 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v1,3/3] pinctrl: mpfs-mssio: use correct regmap function to set bank voltage"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1745.53 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v1,3/3] pinctrl: mpfs-mssio: use correct regmap function to set bank voltage"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 28.88 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v1,3/3] pinctrl: mpfs-mssio: use correct regmap function to set bank voltage"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 29.97 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v1,3/3] pinctrl: mpfs-mssio: use correct regmap function to set bank voltage"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.78 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v1,3/3] pinctrl: mpfs-mssio: use correct regmap function to set bank voltage"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 90.62 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v1,3/3] pinctrl: mpfs-mssio: use correct regmap function to set bank voltage"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v1,3/3] pinctrl: mpfs-mssio: use correct regmap function to set bank voltage"
kdoc
Desc: Detects for kdoc errors
Duration: 1.06 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v1,3/3] pinctrl: mpfs-mssio: use correct regmap function to set bank voltage"
module-param
Desc: Detect module_param changes
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v1,3/3] pinctrl: mpfs-mssio: use correct regmap function to set bank voltage"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 31, 2026

Copy link
Copy Markdown
Author

Patch 3: "[v1,3/3] pinctrl: mpfs-mssio: use correct regmap function to set bank voltage"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.32 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot force-pushed the workflow__riscv__fixes branch 2 times, most recently from 1252e7d to cf66746 Compare September 1, 2026 20:29
@linux-riscv-bot
linux-riscv-bot deleted the pw1154419 branch September 1, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@linux-riscv-bot @ThreeBottleCap @SiFiveHolland @dmantipov @tchiu-TT @xhackerustc @ConchuOD