Skip to content

[PW_SID:1155011] KVM: riscv: selftests: Dump sepc/scause/stval on vcpu_arch_dump() - #2559

Open
linux-riscv-bot wants to merge 4 commits into
workflow__riscv__fixesfrom
pw1155011
Open

[PW_SID:1155011] KVM: riscv: selftests: Dump sepc/scause/stval on vcpu_arch_dump()#2559
linux-riscv-bot wants to merge 4 commits into
workflow__riscv__fixesfrom
pw1155011

Conversation

@linux-riscv-bot

Copy link
Copy Markdown

PR for series 1155011 applied to workflow__riscv__fixes

Name: KVM: riscv: selftests: Dump sepc/scause/stval on vcpu_arch_dump()
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1155011
Version: 1

Xixin Liu and others added 4 commits August 31, 2026 19:12
Overflow status and restart masks are u64, but bits were built with
BIT(). On RV32 that is an unsigned long shift, so indices >= 32 truncate
or wrap and corrupt the mask.

Use BIT_ULL() for those u64 bitops.

Fixes: a862521 ("drivers/perf: riscv: Implement SBI PMU snapshot function")
Assisted-by: DeepSeek:deepseek-v3
Signed-off-by: Xixin Liu <liuxixin@kylinos.cn>
Link: https://patch.msgid.link/prpmask01bitul.v2.1786434000.git.liuxixin@kylinos.cn
[pjw@kernel.org: updated to apply]
Signed-off-by: Paul Walmsley <pjw@kernel.org>
The available-counter mask was a single unsigned long, but iteration
uses RISCV_MAX_COUNTERS, which is 64. On RV32 that reads past the object.
Filling with an unsigned-long bit at index 32 and above is also wrong.

Use DECLARE_BITMAP and set_bit/bitmap helpers. Walk each bitmap word
into CFG_MATCH when checking events, when allocating an index, and when
stopping all counters. Set the counter base to i times BITS_PER_LONG.
Share the CFG_MATCH ecall through a small helper so the 32-bit argument
split is not duplicated. On qemu-system-riscv32 the probe bitmap has bits
above XLEN set, so the first word alone is not enough.

Fixes: e999143 ("RISC-V: Add perf platform driver based on SBI PMU extension")
Assisted-by: DeepSeek:deepseek-v3
Signed-off-by: Xixin Liu <liuxixin@kylinos.cn>
Link: https://patch.msgid.link/prpmask02cmap.v2.1786434000.git.liuxixin@kylinos.cn
[pjw@kernel.org: updated to apply]
Signed-off-by: Paul Walmsley <pjw@kernel.org>
vcpu_arch_dump() omits trap-related CSRs, making it hard to diagnose
unexpected guest exceptions from the dump output alone.

Print sepc, scause, and stval alongside the existing register dump.

Signed-off-by: Yong-Xuan Wang <yongxuan.wang@sifive.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "KVM: riscv: selftests: Dump sepc/scause/stval on vcpu_arch_dump()"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 146.71 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "KVM: riscv: selftests: Dump sepc/scause/stval on vcpu_arch_dump()"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1181.94 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "KVM: riscv: selftests: Dump sepc/scause/stval on vcpu_arch_dump()"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1451.73 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "KVM: riscv: selftests: Dump sepc/scause/stval on vcpu_arch_dump()"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 27.17 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "KVM: riscv: selftests: Dump sepc/scause/stval on vcpu_arch_dump()"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 27.90 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "KVM: riscv: selftests: Dump sepc/scause/stval on vcpu_arch_dump()"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.79 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "KVM: riscv: selftests: Dump sepc/scause/stval on vcpu_arch_dump()"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 90.77 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "KVM: riscv: selftests: Dump sepc/scause/stval on vcpu_arch_dump()"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "KVM: riscv: selftests: Dump sepc/scause/stval on vcpu_arch_dump()"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "KVM: riscv: selftests: Dump sepc/scause/stval on vcpu_arch_dump()"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "KVM: riscv: selftests: Dump sepc/scause/stval on vcpu_arch_dump()"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "KVM: riscv: selftests: Dump sepc/scause/stval on vcpu_arch_dump()"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot force-pushed the workflow__riscv__fixes branch 5 times, most recently from 9ed823f to a54e736 Compare September 2, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants