Skip to content

[PW_SID:1155091] firmware: microchip: use kzalloc_objs() instead of kzalloc() with multiply - #2561

Closed
linux-riscv-bot wants to merge 4 commits into
workflow__riscv__fixesfrom
pw1155091
Closed

[PW_SID:1155091] firmware: microchip: use kzalloc_objs() instead of kzalloc() with multiply#2561
linux-riscv-bot wants to merge 4 commits into
workflow__riscv__fixesfrom
pw1155091

Conversation

@linux-riscv-bot

@linux-riscv-bot linux-riscv-bot commented Sep 1, 2026

Copy link
Copy Markdown

PR for series 1155091 applied to workflow__riscv__fixes

Name: firmware: microchip: use kzalloc_objs() instead of kzalloc() with multiply
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1155091
Version: 1

Xixin Liu and others added 4 commits August 31, 2026 19:12
Xixin Liu Paul Walmsley
perf: RISC-V: use BIT_ULL for u64 overflow masks
79be3cf 
Overflow status and restart masks are u64, but bits were built with
BIT(). On RV32 that is an unsigned long shift, so indices >= 32 truncate
or wrap and corrupt the mask.

Use BIT_ULL() for those u64 bitops.

Fixes: a862521 ("drivers/perf: riscv: Implement SBI PMU snapshot function")
Assisted-by: DeepSeek:deepseek-v3
Signed-off-by: Xixin Liu <liuxixin@kylinos.cn>
Link: https://patch.msgid.link/prpmask01bitul.v2.1786434000.git.liuxixin@kylinos.cn
[pjw@kernel.org: updated to apply]
Signed-off-by: Paul Walmsley <pjw@kernel.org>
Xixin Liu Paul Walmsley
perf: RISC-V: store available counter mask as bitmap
e7bdbf5 
The available-counter mask was a single unsigned long, but iteration
uses RISCV_MAX_COUNTERS, which is 64. On RV32 that reads past the object.
Filling with an unsigned-long bit at index 32 and above is also wrong.

Use DECLARE_BITMAP and set_bit/bitmap helpers. Walk each bitmap word
into CFG_MATCH when checking events, when allocating an index, and when
stopping all counters. Set the counter base to i times BITS_PER_LONG.
Share the CFG_MATCH ecall through a small helper so the 32-bit argument
split is not duplicated. On qemu-system-riscv32 the probe bitmap has bits
above XLEN set, so the first word alone is not enough.

Fixes: e999143 ("RISC-V: Add perf platform driver based on SBI PMU extension")
Assisted-by: DeepSeek:deepseek-v3
Signed-off-by: Xixin Liu <liuxixin@kylinos.cn>
Link: https://patch.msgid.link/prpmask02cmap.v2.1786434000.git.liuxixin@kylinos.cn
[pjw@kernel.org: updated to apply]
Signed-off-by: Paul Walmsley <pjw@kernel.org>
Linux RISC-V bot
Adding CI files
1252e7d
@hrushirajg23 Linux RISC-V bot
firmware: microchip: use kzalloc_objs() instead of kzalloc() with mul…
f084215 
…tiply

response_msg is sized as
AUTO_UPDATE_FEATURE_RESP_SIZE * sizeof(*response_msg) by hand in both
call sites. Use kzalloc_objs() instead, matching the kzalloc_obj()
already used elsewhere in this same file for the other allocations in
these functions, and getting the same overflow-checked size
computation kzalloc_obj() already benefits from.

No functional change.

Signed-off-by: Hrushiraj Gandhi <hrushirajg23@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

linux-riscv-bot commented Sep 1, 2026

Copy link
Copy Markdown
Author

Patch 1: "firmware: microchip: use kzalloc_objs() instead of kzalloc() with multiply"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 141.81 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 1, 2026

Copy link
Copy Markdown
Author

Patch 1: "firmware: microchip: use kzalloc_objs() instead of kzalloc() with multiply"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1190.61 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 1, 2026

Copy link
Copy Markdown
Author

Patch 1: "firmware: microchip: use kzalloc_objs() instead of kzalloc() with multiply"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1497.75 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 1, 2026

Copy link
Copy Markdown
Author

Patch 1: "firmware: microchip: use kzalloc_objs() instead of kzalloc() with multiply"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.60 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 1, 2026

Copy link
Copy Markdown
Author

Patch 1: "firmware: microchip: use kzalloc_objs() instead of kzalloc() with multiply"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.12 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 1, 2026

Copy link
Copy Markdown
Author

Patch 1: "firmware: microchip: use kzalloc_objs() instead of kzalloc() with multiply"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.82 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 1, 2026

Copy link
Copy Markdown
Author

Patch 1: "firmware: microchip: use kzalloc_objs() instead of kzalloc() with multiply"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 96.01 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 1, 2026

Copy link
Copy Markdown
Author

Patch 1: "firmware: microchip: use kzalloc_objs() instead of kzalloc() with multiply"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.67 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 1, 2026

Copy link
Copy Markdown
Author

Patch 1: "firmware: microchip: use kzalloc_objs() instead of kzalloc() with multiply"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 1, 2026

Copy link
Copy Markdown
Author

Patch 1: "firmware: microchip: use kzalloc_objs() instead of kzalloc() with multiply"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 1, 2026

Copy link
Copy Markdown
Author

Patch 1: "firmware: microchip: use kzalloc_objs() instead of kzalloc() with multiply"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 1, 2026

Copy link
Copy Markdown
Author

Patch 1: "firmware: microchip: use kzalloc_objs() instead of kzalloc() with multiply"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.34 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot force-pushed the workflow__riscv__fixes branch 5 times, most recently from 9ed823f to a54e736 Compare September 2, 2026 20:29
@linux-riscv-bot
linux-riscv-bot deleted the pw1155091 branch September 2, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @hrushirajg23