Skip to content

[PW_SID:1158337] Fix timed may_goto with private stacks - #2595

Open
linux-riscv-bot wants to merge 7 commits into
workflow__riscv__fixesfrom
pw1158337
Open

[PW_SID:1158337] Fix timed may_goto with private stacks#2595
linux-riscv-bot wants to merge 7 commits into
workflow__riscv__fixesfrom
pw1158337

Conversation

@linux-riscv-bot

@linux-riscv-bot linux-riscv-bot commented Sep 4, 2026

Copy link
Copy Markdown

PR for series 1158337 applied to workflow__riscv__fixes

Name: Fix timed may_goto with private stacks
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1158337
Version: 1

@sidchintamaneni Linux RISC-V bot
bpf: Fix timed may_goto stack pointer for private stacks
39c38e3 
timed may_goto passes a stack offset to the architecture trampoline,
which reconstructs the counter pointer from its BPF frame pointer. This
breaks when the JIT uses a private stack with a different frame pointer.

Resolve the counter pointer in the fixup using BPF_REG_FP and pass the
pointer through BPF_REG_AX. Account for the extra instruction in the
internal branch offsets.

Fixes: e723608 ("bpf: Add verifier support for timed may_goto")
Reported-by: Jeremy Jean <jeremy.jean@oss.cyber.gouv.fr>
Link: https://lore.kernel.org/all/20260824213158.3755932-2-Jeremy.Jean@oss.cyber.gouv.fr/
Signed-off-by: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@sidchintamaneni Linux RISC-V bot
bpf, x86: Use resolved pointer for timed may_goto
9942ab2 
The timed may_goto fixup now passes the resolved counter pointer through
BPF_REG_AX instead of a stack offset.

Use the pointer directly rather than adding it to RBP. This preserves the
private-stack address selected by the JIT through R9.

Fixes: 2fb7618 ("bpf, x86: Add x86 JIT support for timed may_goto")
Reported-by: Jeremy Jean <jeremy.jean@oss.cyber.gouv.fr>
Link: https://lore.kernel.org/all/20260824213158.3755932-2-Jeremy.Jean@oss.cyber.gouv.fr/
Signed-off-by: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@sidchintamaneni Linux RISC-V bot
bpf, arm64: Use resolved pointer for timed may_goto
98c575d 
The timed may_goto fixup now passes the resolved counter pointer through
BPF_REG_AX instead of a stack offset.

Copy the pointer directly into the first argument register rather than
adding it to the BPF frame pointer again.

Fixes: 1617537 ("bpf, arm64: Add JIT support for timed may_goto")
Reported-by: Jeremy Jean <jeremy.jean@oss.cyber.gouv.fr>
Link: https://lore.kernel.org/all/20260824213158.3755932-2-Jeremy.Jean@oss.cyber.gouv.fr/
Assisted-by: Copilot:gpt-5.6-sol
Signed-off-by: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@sidchintamaneni Linux RISC-V bot
bpf, powerpc64: Use resolved pointer for timed may_goto
cbb6d28 
The timed may_goto fixup now passes the resolved counter pointer through
BPF_REG_AX instead of a stack offset.

Copy the pointer directly into the first argument register rather than
adding it to the BPF frame pointer again.

Fixes: b55b6b9 ("powerpc64/bpf: Add powerpc64 JIT support for timed may_goto")
Reported-by: Jeremy Jean <jeremy.jean@oss.cyber.gouv.fr>
Link: https://lore.kernel.org/all/20260824213158.3755932-2-Jeremy.Jean@oss.cyber.gouv.fr/
Assisted-by: Copilot:gpt-5.6-sol
Signed-off-by: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@sidchintamaneni Linux RISC-V bot
bpf, riscv: Use resolved pointer for timed may_goto
03857ef 
The timed may_goto fixup now passes the resolved counter pointer through
BPF_REG_AX instead of a stack offset.

Copy the pointer directly into the first argument register rather than
adding it to the BPF frame pointer again.

Fixes: 6ef8ff2 ("bpf, riscv: Add support for timed may_goto")
Reported-by: Jeremy Jean <jeremy.jean@oss.cyber.gouv.fr>
Link: https://lore.kernel.org/all/20260824213158.3755932-2-Jeremy.Jean@oss.cyber.gouv.fr/
Assisted-by: Copilot:gpt-5.6-sol
Signed-off-by: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@sidchintamaneni Linux RISC-V bot
bpf, s390: Use resolved pointer for timed may_goto
b0e1fe8 
The timed may_goto fixup now passes the resolved counter pointer through
BPF_REG_AX instead of a stack offset and BPF frame pointer pair.

Copy the pointer directly into the first argument register and update the
special calling convention documentation.

Fixes: b8efa81 ("s390/bpf: Add s390 JIT support for timed may_goto")
Reported-by: Jeremy Jean <jeremy.jean@oss.cyber.gouv.fr>
Link: https://lore.kernel.org/all/20260824213158.3755932-2-Jeremy.Jean@oss.cyber.gouv.fr/
Assisted-by: Copilot:gpt-5.6-sol
Signed-off-by: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@sidchintamaneni Linux RISC-V bot
selftests/bpf: Test timed may_goto with private stacks
6e484de 
Add private_stack_timed_may_goto() with enough stack usage to select a
private stack. Check that the JIT uses the private-stack frame pointer
when constructing the pointer passed to the architecture trampoline.

Update the translated instruction expectations in may_goto_batch_2(),
may_goto_interaction_x86_64(), and may_goto_interaction() for the
additional pointer construction instruction and adjusted branch offsets.

Signed-off-by: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

linux-riscv-bot commented Sep 5, 2026

Copy link
Copy Markdown
Author

Patch 1: "[bpf-next,v1,1/7] bpf: Fix timed may_goto stack pointer for private stacks"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 142.68 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 5, 2026

Copy link
Copy Markdown
Author

Patch 1: "[bpf-next,v1,1/7] bpf: Fix timed may_goto stack pointer for private stacks"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1468.11 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 5, 2026

Copy link
Copy Markdown
Author

Patch 1: "[bpf-next,v1,1/7] bpf: Fix timed may_goto stack pointer for private stacks"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1813.12 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 5, 2026

Copy link
Copy Markdown
Author

Patch 1: "[bpf-next,v1,1/7] bpf: Fix timed may_goto stack pointer for private stacks"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.57 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 5, 2026

Copy link
Copy Markdown
Author

Patch 1: "[bpf-next,v1,1/7] bpf: Fix timed may_goto stack pointer for private stacks"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 27.89 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 5, 2026

Copy link
Copy Markdown
Author

Patch 1: "[bpf-next,v1,1/7] bpf: Fix timed may_goto stack pointer for private stacks"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.75 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 5, 2026

Copy link
Copy Markdown
Author

Patch 1: "[bpf-next,v1,1/7] bpf: Fix timed may_goto stack pointer for private stacks"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 90.63 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 5, 2026

Copy link
Copy Markdown
Author

Patch 1: "[bpf-next,v1,1/7] bpf: Fix timed may_goto stack pointer for private stacks"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 5, 2026

Copy link
Copy Markdown
Author

Patch 1: "[bpf-next,v1,1/7] bpf: Fix timed may_goto stack pointer for private stacks"
kdoc
Desc: Detects for kdoc errors
Duration: 0.80 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 5, 2026

Copy link
Copy Markdown
Author

Patch 1: "[bpf-next,v1,1/7] bpf: Fix timed may_goto stack pointer for private stacks"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 5, 2026

Copy link
Copy Markdown
Author

Patch 1: "[bpf-next,v1,1/7] bpf: Fix timed may_goto stack pointer for private stacks"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 5, 2026

Copy link
Copy Markdown
Author

Patch 1: "[bpf-next,v1,1/7] bpf: Fix timed may_goto stack pointer for private stacks"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 5, 2026

Copy link
Copy Markdown
Author

Patch 2: "[bpf-next,v1,2/7] bpf, x86: Use resolved pointer for timed may_goto"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 142.51 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Sep 5, 2026

Copy link
Copy Markdown
Author

Patch 2: "[bpf-next,v1,2/7] bpf, x86: Use resolved pointer for timed may_goto"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1158.63 seconds
Result: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @sidchintamaneni