Skip to content

[PW_SID:987397] clk: spacemit: fix sspax_clk - #713

Closed
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw987397
Closed

[PW_SID:987397] clk: spacemit: fix sspax_clk#713
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw987397

Conversation

@linux-riscv-bot

@linux-riscv-bot linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown

PR for series 987397 applied to workflow__riscv__fixes

Name: clk: spacemit: fix sspax_clk
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=987397
Version: 3

@TroyMitchell911 Linux RISC-V bot
dt-bindings: clock: spacemit: CLK_SSPA_I2S_BCLK for SSPA
9ff8cb3 
In order to use the virtual clock SSPAx_I2S_BCLK in the device tree and
register it in the driver, this patch introduces the macro definition.

Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@TroyMitchell911 Linux RISC-V bot
clk: spacemit: fix sspax_clk
41c34b4 
Hardware Requirement:
When FNCLKSEL in APBC_SSPAX_CLK_RST is set to 7 (3'b111),
BIT3 must be set to 1 for the SSPAx parent clock to be I2S_BCLK.

This patch introduces SSPAx_I2S_BCLK as a virtual gate to enable BIT3.

Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Suggested-by: Yao Zi <ziyao@disroot.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 1: "[RESEND,v3,1/2] dt-bindings: clock: spacemit: CLK_SSPA_I2S_BCLK for SSPA"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 104.03 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 1: "[RESEND,v3,1/2] dt-bindings: clock: spacemit: CLK_SSPA_I2S_BCLK for SSPA"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1012.94 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 1: "[RESEND,v3,1/2] dt-bindings: clock: spacemit: CLK_SSPA_I2S_BCLK for SSPA"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1371.87 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 1: "[RESEND,v3,1/2] dt-bindings: clock: spacemit: CLK_SSPA_I2S_BCLK for SSPA"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.84 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 1: "[RESEND,v3,1/2] dt-bindings: clock: spacemit: CLK_SSPA_I2S_BCLK for SSPA"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.72 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 1: "[RESEND,v3,1/2] dt-bindings: clock: spacemit: CLK_SSPA_I2S_BCLK for SSPA"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.73 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 1: "[RESEND,v3,1/2] dt-bindings: clock: spacemit: CLK_SSPA_I2S_BCLK for SSPA"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 72.00 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 1: "[RESEND,v3,1/2] dt-bindings: clock: spacemit: CLK_SSPA_I2S_BCLK for SSPA"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 1: "[RESEND,v3,1/2] dt-bindings: clock: spacemit: CLK_SSPA_I2S_BCLK for SSPA"
kdoc
Desc: Detects for kdoc errors
Duration: 1.12 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 1: "[RESEND,v3,1/2] dt-bindings: clock: spacemit: CLK_SSPA_I2S_BCLK for SSPA"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 1: "[RESEND,v3,1/2] dt-bindings: clock: spacemit: CLK_SSPA_I2S_BCLK for SSPA"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 1: "[RESEND,v3,1/2] dt-bindings: clock: spacemit: CLK_SSPA_I2S_BCLK for SSPA"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 2: "[RESEND,v3,2/2] clk: spacemit: fix sspax_clk"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 101.96 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 2: "[RESEND,v3,2/2] clk: spacemit: fix sspax_clk"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 939.71 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 2: "[RESEND,v3,2/2] clk: spacemit: fix sspax_clk"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1284.58 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 2: "[RESEND,v3,2/2] clk: spacemit: fix sspax_clk"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.66 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 2: "[RESEND,v3,2/2] clk: spacemit: fix sspax_clk"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.83 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 2: "[RESEND,v3,2/2] clk: spacemit: fix sspax_clk"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.49 seconds
Result: WARNING
Output:

CHECK: Please use a blank line after function/struct/union/enum declarations
#44: FILE: drivers/clk/spacemit/ccu-k1.c:365:
 };
+CCU_MUX_GATE_DEFINE(sspa0_clk, sspa0_parents, APBC_SSPA0_CLK_RST, 4, 3, BIT(1), 0);

CHECK: Please use a blank line after function/struct/union/enum declarations
#56: FILE: drivers/clk/spacemit/ccu-k1.c:377:
+};
+CCU_MUX_GATE_DEFINE(sspa1_clk, sspa1_parents, APBC_SSPA1_CLK_RST, 4, 3, BIT(1), 0);

total: 0 errors, 0 warnings, 2 checks, 44 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 41c34b4f6b0d ("clk: spacemit: fix sspax_clk") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 2 checks, 44 lines checked
CHECK: Please use a blank line after function/struct/union/enum declarations

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 2: "[RESEND,v3,2/2] clk: spacemit: fix sspax_clk"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 71.65 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 2: "[RESEND,v3,2/2] clk: spacemit: fix sspax_clk"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 2: "[RESEND,v3,2/2] clk: spacemit: fix sspax_clk"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 2: "[RESEND,v3,2/2] clk: spacemit: fix sspax_clk"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 2: "[RESEND,v3,2/2] clk: spacemit: fix sspax_clk"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Jul 31, 2025

Copy link
Copy Markdown
Author

Patch 2: "[RESEND,v3,2/2] clk: spacemit: fix sspax_clk"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot deleted the pw987397 branch August 5, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @TroyMitchell911