Skip to content

[PW_SID:990302] Add Ethernet MAC support for SpacemiT K1 - #756

Closed
linux-riscv-bot wants to merge 5 commits into
workflow__riscv__fixesfrom
pw990302
Closed

[PW_SID:990302] Add Ethernet MAC support for SpacemiT K1#756
linux-riscv-bot wants to merge 5 commits into
workflow__riscv__fixesfrom
pw990302

Conversation

@linux-riscv-bot

Copy link
Copy Markdown

PR for series 990302 applied to workflow__riscv__fixes

Name: Add Ethernet MAC support for SpacemiT K1
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=990302
Version: 5

The Ethernet MACs on SpacemiT K1 appears to be a custom design. SpacemiT
refers to them as "EMAC", so let's just call them "spacemit,k1-emac".

Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
The Ethernet MACs found on SpacemiT K1 appears to be a custom design
that only superficially resembles some other embedded MACs. SpacemiT
refers to them as "EMAC", so let's just call the driver "k1_emac".

Supports RGMII and RMII interfaces. Includes support for MAC hardware
statistics counters. PTP support is not implemented.

Tested-by: Junhui Liu <junhui.liu@pigmoral.tech>
Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Add nodes for each of the two Ethernet MACs on K1 with generic
properties. Also add "gmac" pins to pinctrl config.

Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Banana Pi BPI-F3 uses an RGMII PHY for each port and uses GPIO for PHY
reset.

Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Milk-V Jupiter uses an RGMII PHY for each port and uses GPIO for PHY
reset.

Signed-off-by: Vivian Wang <wangruikang@iscas.ac.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v5,1/5] dt-bindings: net: Add support for SpacemiT K1"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 105.76 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v5,1/5] dt-bindings: net: Add support for SpacemiT K1"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1054.39 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v5,1/5] dt-bindings: net: Add support for SpacemiT K1"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1361.47 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v5,1/5] dt-bindings: net: Add support for SpacemiT K1"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.48 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v5,1/5] dt-bindings: net: Add support for SpacemiT K1"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.57 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v5,1/5] dt-bindings: net: Add support for SpacemiT K1"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.93 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 81 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 40616cb4cd90 ("dt-bindings: net: Add support for SpacemiT K1") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 81 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?


@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v5,1/5] dt-bindings: net: Add support for SpacemiT K1"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 75.79 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v5,1/5] dt-bindings: net: Add support for SpacemiT K1"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v5,1/5] dt-bindings: net: Add support for SpacemiT K1"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v5,1/5] dt-bindings: net: Add support for SpacemiT K1"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v5,1/5] dt-bindings: net: Add support for SpacemiT K1"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 1: "[net-next,v5,1/5] dt-bindings: net: Add support for SpacemiT K1"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v5,2/5] net: spacemit: Add K1 Ethernet MAC"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 109.82 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v5,2/5] net: spacemit: Add K1 Ethernet MAC"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1152.87 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v5,2/5] net: spacemit: Add K1 Ethernet MAC"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1629.16 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v5,2/5] net: spacemit: Add K1 Ethernet MAC"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.38 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v5,2/5] net: spacemit: Add K1 Ethernet MAC"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.85 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v5,2/5] net: spacemit: Add K1 Ethernet MAC"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 43.98 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines
#74: FILE: drivers/net/ethernet/spacemit/Kconfig:16:
+config SPACEMIT_K1_EMAC
+	tristate "SpacemiT K1 Ethernet MAC driver"
+	depends on ARCH_SPACEMIT || COMPILE_TEST
+	depends on MFD_SYSCON
+	depends on OF
+	default m if ARCH_SPACEMIT
+	select PHYLIB
+	help
+	  This driver supports the Ethernet MAC in the SpacemiT K1 SoC.
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called k1_emac.
+

total: 0 errors, 2 warnings, 0 checks, 2522 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit da875d7d615f ("net: spacemit: Add K1 Ethernet MAC") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 2 warnings, 0 checks, 2522 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines


@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v5,2/5] net: spacemit: Add K1 Ethernet MAC"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 75.16 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v5,2/5] net: spacemit: Add K1 Ethernet MAC"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v5,2/5] net: spacemit: Add K1 Ethernet MAC"
kdoc
Desc: Detects for kdoc errors
Duration: 0.94 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v5,2/5] net: spacemit: Add K1 Ethernet MAC"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v5,2/5] net: spacemit: Add K1 Ethernet MAC"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 2: "[net-next,v5,2/5] net: spacemit: Add K1 Ethernet MAC"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.33 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 3: "[net-next,v5,3/5] riscv: dts: spacemit: Add Ethernet support for K1"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 106.68 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 3: "[net-next,v5,3/5] riscv: dts: spacemit: Add Ethernet support for K1"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 77.06 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 3: "[net-next,v5,3/5] riscv: dts: spacemit: Add Ethernet support for K1"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 3: "[net-next,v5,3/5] riscv: dts: spacemit: Add Ethernet support for K1"
kdoc
Desc: Detects for kdoc errors
Duration: 0.85 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 3: "[net-next,v5,3/5] riscv: dts: spacemit: Add Ethernet support for K1"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 3: "[net-next,v5,3/5] riscv: dts: spacemit: Add Ethernet support for K1"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 3: "[net-next,v5,3/5] riscv: dts: spacemit: Add Ethernet support for K1"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.33 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 4: "[net-next,v5,4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 106.39 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 4: "[net-next,v5,4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1102.46 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 4: "[net-next,v5,4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1418.78 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 4: "[net-next,v5,4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.65 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 4: "[net-next,v5,4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.67 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 4: "[net-next,v5,4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.70 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 4: "[net-next,v5,4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 75.80 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 4: "[net-next,v5,4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 4: "[net-next,v5,4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 4: "[net-next,v5,4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 4: "[net-next,v5,4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 4: "[net-next,v5,4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.33 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 5: "[net-next,v5,5/5] riscv: dts: spacemit: Add Ethernet support for Jupiter"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 106.53 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 5: "[net-next,v5,5/5] riscv: dts: spacemit: Add Ethernet support for Jupiter"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1106.61 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 5: "[net-next,v5,5/5] riscv: dts: spacemit: Add Ethernet support for Jupiter"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1424.29 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 5: "[net-next,v5,5/5] riscv: dts: spacemit: Add Ethernet support for Jupiter"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.44 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 5: "[net-next,v5,5/5] riscv: dts: spacemit: Add Ethernet support for Jupiter"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.90 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 5: "[net-next,v5,5/5] riscv: dts: spacemit: Add Ethernet support for Jupiter"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.70 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 5: "[net-next,v5,5/5] riscv: dts: spacemit: Add Ethernet support for Jupiter"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 75.60 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 5: "[net-next,v5,5/5] riscv: dts: spacemit: Add Ethernet support for Jupiter"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 5: "[net-next,v5,5/5] riscv: dts: spacemit: Add Ethernet support for Jupiter"
kdoc
Desc: Detects for kdoc errors
Duration: 0.90 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 5: "[net-next,v5,5/5] riscv: dts: spacemit: Add Ethernet support for Jupiter"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 5: "[net-next,v5,5/5] riscv: dts: spacemit: Add Ethernet support for Jupiter"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

Copy link
Copy Markdown
Author

Patch 5: "[net-next,v5,5/5] riscv: dts: spacemit: Add Ethernet support for Jupiter"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.32 seconds
Result: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants