Skip to content

[PW_SID:990808] [v2] dt-bindings: serial: 8250: allow "main" and "uart" as clock names - #763

Closed
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw990808
Closed

[PW_SID:990808] [v2] dt-bindings: serial: 8250: allow "main" and "uart" as clock names#763
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw990808

Conversation

@linux-riscv-bot

@linux-riscv-bot linux-riscv-bot commented Aug 13, 2025

Copy link
Copy Markdown

PR for series 990808 applied to workflow__riscv__fixes

Name: [v2] dt-bindings: serial: 8250: allow "main" and "uart" as clock names
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=990808
Version: 2

@alexelder Linux RISC-V bot
dt-bindings: serial: 8250: allow "main" and "uart" as clock names
6bd3e5f 
There are two compatible strings defined in "8250.yaml" that require
two clocks to be specified, along with their names:
  - "spacemit,k1-uart", used in "spacemit/k1.dtsi"
  - "nxp,lpc1850-uart", used in "lpc/lpc18xx.dtsi"

When only one clock is used, the name is not required.  However there
are two places that do specify a name:
  - In "mediatek/mt7623.dtsi", the clock for the "mediatek,mtk-btif"
    compatible serial device is named "main"
  - In "qca/ar9132.dtsi", the clock for the "ns8250" compatible
    serial device is named "uart"

In commit d2db0d7 ("dt-bindings: serial: 8250: allow clock
'uartclk' and 'reg' for nxp,lpc1850-uart"), Frank Li added the
restriction that two named clocks be used for the NXP platform
mentioned above.

Change that logic, so that an additional condition for (only) the
SpacemiT platform similarly restricts the two clocks to have the
names "core" and "bus".

Finally, add "main" and "uart" as allowed names when a single clock is
specified.

Fixes: 2c0594f ("dt-bindings: serial: 8250: support an optional second clock")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507160314.wrC51lXX-lkp@intel.com/
Signed-off-by: Alex Elder <elder@riscstar.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

linux-riscv-bot commented Aug 13, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] dt-bindings: serial: 8250: allow "main" and "uart" as clock names"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 104.25 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 13, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] dt-bindings: serial: 8250: allow "main" and "uart" as clock names"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1032.93 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 13, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] dt-bindings: serial: 8250: allow "main" and "uart" as clock names"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1326.15 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 13, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] dt-bindings: serial: 8250: allow "main" and "uart" as clock names"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.22 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 13, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] dt-bindings: serial: 8250: allow "main" and "uart" as clock names"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.04 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 13, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] dt-bindings: serial: 8250: allow "main" and "uart" as clock names"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.65 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 13, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] dt-bindings: serial: 8250: allow "main" and "uart" as clock names"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 75.02 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 13, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] dt-bindings: serial: 8250: allow "main" and "uart" as clock names"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 13, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] dt-bindings: serial: 8250: allow "main" and "uart" as clock names"
kdoc
Desc: Detects for kdoc errors
Duration: 0.84 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 13, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] dt-bindings: serial: 8250: allow "main" and "uart" as clock names"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 13, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] dt-bindings: serial: 8250: allow "main" and "uart" as clock names"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 13, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] dt-bindings: serial: 8250: allow "main" and "uart" as clock names"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot deleted the pw990808 branch August 13, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @alexelder