Skip to content

[PW_SID:991461] [v3] i2c: spacemit: configure ILCR for accurate SCL frequency - #775

Closed
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw991461
Closed

[PW_SID:991461] [v3] i2c: spacemit: configure ILCR for accurate SCL frequency#775
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw991461

Conversation

@linux-riscv-bot

@linux-riscv-bot linux-riscv-bot commented Aug 14, 2025

Copy link
Copy Markdown

PR for series 991461 applied to workflow__riscv__fixes

Name: [v3] i2c: spacemit: configure ILCR for accurate SCL frequency
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=991461
Version: 3

@TroyMitchell911 Linux RISC-V bot
i2c: spacemit: configure ILCR for accurate SCL frequency
6475790 
The SpacemiT I2C controller's SCL (Serial Clock Line) frequency for
master mode operations is determined by the ILCR (I2C Load Count Register).
Previously, the driver relied on the hardware's reset default
values for this register.

The hardware's default ILCR values (SLV=0x156, FLV=0x5d) yield SCL
frequencies lower than intended. For example, with the default
31.5 MHz input clock, these default settings result in an SCL
frequency of approximately 93 kHz (standard mode) when targeting 100 kHz,
and approximately 338 kHz (fast mode) when targeting 400 kHz.
These frequencies are below the 100 kHz/400 kHz nominal speeds.

This patch integrates the SCL frequency management into
the Common Clock Framework (CCF). Specifically, the ILCR register,
which acts as a frequency divider for the SCL clock, is now registered
as a managed clock (scl_clk) within the CCF.

This patch also cleans up unnecessary whitespace
in the included header files.

Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

linux-riscv-bot commented Aug 14, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3] i2c: spacemit: configure ILCR for accurate SCL frequency"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 106.24 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 14, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3] i2c: spacemit: configure ILCR for accurate SCL frequency"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1078.90 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 14, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3] i2c: spacemit: configure ILCR for accurate SCL frequency"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1389.15 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 14, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3] i2c: spacemit: configure ILCR for accurate SCL frequency"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.39 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 14, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3] i2c: spacemit: configure ILCR for accurate SCL frequency"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.47 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 14, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3] i2c: spacemit: configure ILCR for accurate SCL frequency"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.29 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 14, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3] i2c: spacemit: configure ILCR for accurate SCL frequency"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 75.16 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 14, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3] i2c: spacemit: configure ILCR for accurate SCL frequency"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 14, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3] i2c: spacemit: configure ILCR for accurate SCL frequency"
kdoc
Desc: Detects for kdoc errors
Duration: 0.90 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 14, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3] i2c: spacemit: configure ILCR for accurate SCL frequency"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 14, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3] i2c: spacemit: configure ILCR for accurate SCL frequency"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 14, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3] i2c: spacemit: configure ILCR for accurate SCL frequency"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot deleted the pw991461 branch August 21, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @TroyMitchell911