Skip to content

[PW_SID:992438] Poweroff/reboot support for TH1520 via AON - #793

Closed
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw992438
Closed

[PW_SID:992438] Poweroff/reboot support for TH1520 via AON#793
linux-riscv-bot wants to merge 2 commits into
workflow__riscv__fixesfrom
pw992438

Conversation

@linux-riscv-bot

@linux-riscv-bot linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown

PR for series 992438 applied to workflow__riscv__fixes

Name: Poweroff/reboot support for TH1520 via AON
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=992438
Version: 1

Icenowy added 2 commits August 18, 2025 08:26
@Icenowy Linux RISC-V bot
driver: reset: th1520-aon: add driver for poweroff/reboot via AON FW
22fda09 
This driver implements poweroff/reboot support for T-Head TH1520 SoCs
running the AON firmware by sending a message to the AON firmware's WDG
part.

This is a auxiliary device driver, and expects the AON channel to be
passed via the platform_data of the auxiliary device.

Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@Icenowy Linux RISC-V bot
pmdomain: thead: create auxiliary device for rebooting
ced5a18 
The reboot / power off operations require communication with the AON
firmware too.

As the driver is already present, create an auxiliary device with name
"reboot" to match that driver, and pass the AON channel by using
platform_data.

Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/2] driver: reset: th1520-aon: add driver for poweroff/reboot via AON FW"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 103.40 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/2] driver: reset: th1520-aon: add driver for poweroff/reboot via AON FW"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1059.18 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/2] driver: reset: th1520-aon: add driver for poweroff/reboot via AON FW"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1369.63 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/2] driver: reset: th1520-aon: add driver for poweroff/reboot via AON FW"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.86 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/2] driver: reset: th1520-aon: add driver for poweroff/reboot via AON FW"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.76 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/2] driver: reset: th1520-aon: add driver for poweroff/reboot via AON FW"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.59 seconds
Result: WARNING
Output:

WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines
#44: FILE: drivers/power/reset/Kconfig:228:
+config POWER_RESET_TH1520_AON
+	tristate "T-Head TH1520 AON firmware poweroff and reset driver"
+	depends on TH1520_PM_DOMAINS
+	help
+	  This driver supports power-off and reset operations for T-Head
+	  TH1520 SoCs running the AON firmware.
+

CHECK: Alignment should match open parenthesis
#123: FILE: drivers/power/reset/th1520-aon-reboot.c:52:
+static int th1520_aon_reboot_probe(struct auxiliary_device *adev,
+				  const struct auxiliary_device_id *id)

total: 0 errors, 1 warnings, 1 checks, 125 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 22fda09b253b ("driver: reset: th1520-aon: add driver for poweroff/reboot via AON FW") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 1 checks, 125 lines checked
CHECK: Alignment should match open parenthesis
WARNING: please write a help paragraph that fully describes the config symbol with at least 4 lines

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/2] driver: reset: th1520-aon: add driver for poweroff/reboot via AON FW"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 74.77 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/2] driver: reset: th1520-aon: add driver for poweroff/reboot via AON FW"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/2] driver: reset: th1520-aon: add driver for poweroff/reboot via AON FW"
kdoc
Desc: Detects for kdoc errors
Duration: 0.91 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/2] driver: reset: th1520-aon: add driver for poweroff/reboot via AON FW"
module-param
Desc: Detect module_param changes
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/2] driver: reset: th1520-aon: add driver for poweroff/reboot via AON FW"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/2] driver: reset: th1520-aon: add driver for poweroff/reboot via AON FW"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/2] pmdomain: thead: create auxiliary device for rebooting"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 103.56 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/2] pmdomain: thead: create auxiliary device for rebooting"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1051.68 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/2] pmdomain: thead: create auxiliary device for rebooting"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1358.43 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/2] pmdomain: thead: create auxiliary device for rebooting"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.30 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/2] pmdomain: thead: create auxiliary device for rebooting"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.02 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/2] pmdomain: thead: create auxiliary device for rebooting"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.74 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/2] pmdomain: thead: create auxiliary device for rebooting"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 77.41 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/2] pmdomain: thead: create auxiliary device for rebooting"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/2] pmdomain: thead: create auxiliary device for rebooting"
kdoc
Desc: Detects for kdoc errors
Duration: 0.86 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/2] pmdomain: thead: create auxiliary device for rebooting"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/2] pmdomain: thead: create auxiliary device for rebooting"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/2] pmdomain: thead: create auxiliary device for rebooting"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot deleted the pw992438 branch August 18, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @Icenowy