Skip to content

[PW_SID:992609] [v2] asm-generic: Remove pud_user() from pgtable-nopmd.h - #795

Closed
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw992609
Closed

[PW_SID:992609] [v2] asm-generic: Remove pud_user() from pgtable-nopmd.h#795
linux-riscv-bot wants to merge 1 commit into
workflow__riscv__fixesfrom
pw992609

Conversation

@linux-riscv-bot

@linux-riscv-bot linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown

PR for series 992609 applied to workflow__riscv__fixes

Name: [v2] asm-generic: Remove pud_user() from pgtable-nopmd.h
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=992609
Version: 2

@chleroy Linux RISC-V bot
asm-generic: Remove pud_user() from pgtable-nopmd.h
4ae979c 
Commit 2c8a81d ("riscv/mm: fix two page table check related
issues") added pud_user() in include/asm-generic/pgtable-nopmd.h

But pud_user() only exists on ARM64 and RISCV and is not expected
by any part of MM.

Add the missing definition in arch/riscv/include/asm/pgtable-32.h
and remove it from asm-generic/pgtable-nopmd.h

A stub pud_user() is also required for ARM64 after
commit ed928a3 ("arm64/mm: fix page table check compile
error for CONFIG_PGTABLE_LEVELS=2")

Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
Acked-by: Alexandre Ghiti <alexghiti@rivosinc.com> # riscv
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] asm-generic: Remove pud_user() from pgtable-nopmd.h"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 103.45 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] asm-generic: Remove pud_user() from pgtable-nopmd.h"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1075.75 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] asm-generic: Remove pud_user() from pgtable-nopmd.h"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1375.93 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] asm-generic: Remove pud_user() from pgtable-nopmd.h"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.74 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] asm-generic: Remove pud_user() from pgtable-nopmd.h"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.64 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] asm-generic: Remove pud_user() from pgtable-nopmd.h"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.07 seconds
Result: WARNING
Output:

WARNING: Argument 'pud' is not used in function-like macro
#39: FILE: arch/arm64/include/asm/pgtable.h:958:
+#define pud_user(pud)		false /* Always 0 with folding */

total: 0 errors, 1 warnings, 0 checks, 23 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 4ae979c3dda9 ("asm-generic: Remove pud_user() from pgtable-nopmd.h") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 23 lines checked
WARNING: Argument 'pud' is not used in function-like macro

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] asm-generic: Remove pud_user() from pgtable-nopmd.h"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 74.80 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] asm-generic: Remove pud_user() from pgtable-nopmd.h"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] asm-generic: Remove pud_user() from pgtable-nopmd.h"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] asm-generic: Remove pud_user() from pgtable-nopmd.h"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] asm-generic: Remove pud_user() from pgtable-nopmd.h"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 18, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v2] asm-generic: Remove pud_user() from pgtable-nopmd.h"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot deleted the pw992609 branch August 26, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @chleroy