Skip to content

[PW_SID:992795] clk: spacemit: fix i2s clock - #798

Closed
linux-riscv-bot wants to merge 3 commits into
workflow__riscv__fixesfrom
pw992795
Closed

[PW_SID:992795] clk: spacemit: fix i2s clock#798
linux-riscv-bot wants to merge 3 commits into
workflow__riscv__fixesfrom
pw992795

Conversation

@linux-riscv-bot

@linux-riscv-bot linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown

PR for series 992795 applied to workflow__riscv__fixes

Name: clk: spacemit: fix i2s clock
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=992795
Version: 4

@TroyMitchell911 Linux RISC-V bot
dt-bindings: clock: spacemit: introduce i2s pre-clock to fix i2s clock
729c538 
Previously, the K1 clock driver did not include the parent clocks of
the I2S sysclk.

Introduce pre-clock to fix I2S clock.

Otherwise, the I2S clock may not work as expected.

This patch adds their definitions to allow proper registration
in the driver and usage in the device tree.

Fixes: 1b72c59 ("clk: spacemit: Add clock support for SpacemiT K1 SoC")
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@TroyMitchell911 Linux RISC-V bot
clk: spacemit: introduce pre-div for ddn clock
89da704 
The original DDN operations applied an implicit divide-by-2, which should
not be a default behavior.

This patch removes that assumption, letting each clock define its
actual behavior explicitly.

Reviewed-by: Haylen Chu <heylenay@4d2.org>
Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@TroyMitchell911 Linux RISC-V bot
clk: spacemit: fix i2s clock
c28458e 
Defining i2s_bclk and i2s_sysclk as fixed-rate clocks is insufficient
for real I2S use cases.

Moreover, the current I2S clock configuration does not work as expected
due to missing parent clocks.

This patch adds the missing parent clocks, defines i2s_sysclk as
a DDN clock, and i2s_bclk as a DIV clock.

A special note for i2s_bclk:

From the register definition, the i2s_bclk divider always implies
an additional 1/2 factor.

The following table shows the correspondence between index
and frequency division coefficients:

| index |  div  |
|-------|-------|
|   0   |   2   |
|   1   |   4   |
|   2   |   6   |
|   3   |   8   |

From a software perspective, introducing i2s_bclk_factor as the
parent of i2s_bclk is sufficient to address the issue.

The I2S-related clock registers can be found here [1].

Link:
https://developer.spacemit.com/documentation?token=LCrKwWDasiJuROkVNusc2pWTnEb
[1]

Fixes: 1b72c59 ("clk: spacemit: Add clock support for SpacemiT K1 SoC")
Co-developer: Jinmei Wei <weijinmei@linux.spacemit.com>
Suggested-by: Haylen Chu <heylenay@4d2.org>
Signed-off-by: Jinmei Wei <weijinmei@linux.spacemit.com>
Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v4,1/3] dt-bindings: clock: spacemit: introduce i2s pre-clock to fix i2s clock"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 106.37 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v4,1/3] dt-bindings: clock: spacemit: introduce i2s pre-clock to fix i2s clock"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1143.45 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v4,1/3] dt-bindings: clock: spacemit: introduce i2s pre-clock to fix i2s clock"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1466.31 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v4,1/3] dt-bindings: clock: spacemit: introduce i2s pre-clock to fix i2s clock"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.11 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v4,1/3] dt-bindings: clock: spacemit: introduce i2s pre-clock to fix i2s clock"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.26 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v4,1/3] dt-bindings: clock: spacemit: introduce i2s pre-clock to fix i2s clock"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.76 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v4,1/3] dt-bindings: clock: spacemit: introduce i2s pre-clock to fix i2s clock"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 75.19 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v4,1/3] dt-bindings: clock: spacemit: introduce i2s pre-clock to fix i2s clock"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v4,1/3] dt-bindings: clock: spacemit: introduce i2s pre-clock to fix i2s clock"
kdoc
Desc: Detects for kdoc errors
Duration: 0.91 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v4,1/3] dt-bindings: clock: spacemit: introduce i2s pre-clock to fix i2s clock"
module-param
Desc: Detect module_param changes
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v4,1/3] dt-bindings: clock: spacemit: introduce i2s pre-clock to fix i2s clock"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v4,1/3] dt-bindings: clock: spacemit: introduce i2s pre-clock to fix i2s clock"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 1.21 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v4,2/3] clk: spacemit: introduce pre-div for ddn clock"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 105.31 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v4,2/3] clk: spacemit: introduce pre-div for ddn clock"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1070.83 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v4,2/3] clk: spacemit: introduce pre-div for ddn clock"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1374.00 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v4,2/3] clk: spacemit: introduce pre-div for ddn clock"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.29 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v4,2/3] clk: spacemit: introduce pre-div for ddn clock"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.31 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v4,2/3] clk: spacemit: introduce pre-div for ddn clock"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.20 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v4,2/3] clk: spacemit: introduce pre-div for ddn clock"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 75.52 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v4,2/3] clk: spacemit: introduce pre-div for ddn clock"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v4,2/3] clk: spacemit: introduce pre-div for ddn clock"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v4,2/3] clk: spacemit: introduce pre-div for ddn clock"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v4,2/3] clk: spacemit: introduce pre-div for ddn clock"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v4,2/3] clk: spacemit: introduce pre-div for ddn clock"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 3: "[v4,3/3] clk: spacemit: fix i2s clock"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 106.09 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 3: "[v4,3/3] clk: spacemit: fix i2s clock"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1090.11 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 3: "[v4,3/3] clk: spacemit: fix i2s clock"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1392.50 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 3: "[v4,3/3] clk: spacemit: fix i2s clock"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.17 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 3: "[v4,3/3] clk: spacemit: fix i2s clock"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.59 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 3: "[v4,3/3] clk: spacemit: fix i2s clock"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.11 seconds
Result: WARNING
Output:

CHECK: Please use a blank line after function/struct/union/enum declarations
#66: FILE: drivers/clk/spacemit/ccu-k1.c:150:
+};
+CCU_MUX_DEFINE(i2s_153p6_base, i2s_153p6_base_parents, MPMU_FCCR, 29, 1, 0);

CHECK: Please use a blank line after function/struct/union/enum declarations
#72: FILE: drivers/clk/spacemit/ccu-k1.c:156:
+};
+CCU_MUX_GATE_DEFINE(i2s_sysclk_src, i2s_sysclk_src_parents, MPMU_ISCCR, 30, 1, BIT(31), 0);

total: 0 errors, 0 warnings, 2 checks, 47 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit c28458edef55 ("clk: spacemit: fix i2s clock") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 2 checks, 47 lines checked
CHECK: Please use a blank line after function/struct/union/enum declarations

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 3: "[v4,3/3] clk: spacemit: fix i2s clock"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 76.04 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 3: "[v4,3/3] clk: spacemit: fix i2s clock"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 3: "[v4,3/3] clk: spacemit: fix i2s clock"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 3: "[v4,3/3] clk: spacemit: fix i2s clock"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 3: "[v4,3/3] clk: spacemit: fix i2s clock"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 19, 2025

Copy link
Copy Markdown
Author

Patch 3: "[v4,3/3] clk: spacemit: fix i2s clock"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot deleted the pw992795 branch August 19, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @TroyMitchell911