[PW_SID:993336] Scope TH1520 reset driver to VO subsystem by linux-riscv-bot · Pull Request #807 · linux-riscv/linux

linux-riscv-bot · 2025-08-20T08:26:13Z

PR for series 993336 applied to workflow__riscv__fixes

Name: Scope TH1520 reset driver to VO subsystem
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=993336
Version: 2

The reset controller driver for the TH1520 was using the generic compatible string "thead,th1520-reset". However, the controller described by this compatible only manages the resets for the Video Output (VO) subsystem. Using a generic compatible is confusing as it implies control over all reset units on the SoC. This could lead to conflicts if support for other reset controllers on the TH1520 is added in the future like AP. Let's introduce a new compatible string, "thead,th1520-reset-vo", to explicitly scope the controller to VO-subsystem. The old one is marked as deprecated. Fixes: 30e7573 ("dt-bindings: reset: Add T-HEAD TH1520 SoC Reset Controller") Cc: stable@vger.kernel.org Reported-by: Icenowy Zheng <uwu@icenowy.me> Co-developed-by: Michal Wilczynski <m.wilczynski@samsung.com> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> Signed-off-by: Yao Zi <ziyao@disroot.org> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

The reset controller for VO-subsystem is previously described with compatible "thead,th1520-reset", which is misleading since it implies control over all reset units on the SoC. A new compatible, "thead,th1520-reset-vo", has been introduced to describe the controller's scope explicitly, while the old one has been deprecated. Let's support the compatible in the driver. Fixes: 4a65326 ("reset: thead: Add TH1520 reset controller driver") Reported-by: Icenowy Zheng <uwu@icenowy.me> Co-developed-by: Michal Wilczynski <m.wilczynski@samsung.com> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> Signed-off-by: Yao Zi <ziyao@disroot.org> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

The only reset-controller described in TH1520's SoC devicetree takes control of reset signals in VO subsystem, while using a generic "thead,th1520-reset" compatible that may imply control over the whole SoC. To avoid such confusion, let's replace the compatible with the new introduced "thead,th1520-reset-vo" that explicitly describes the controller's scope. The controller's label is updated as well. Fixes: 1b136de ("riscv: dts: thead: Introduce reset controller node") Reported-by: Icenowy Zheng <uwu@icenowy.me> Co-developed-by: Michal Wilczynski <m.wilczynski@samsung.com> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com> Signed-off-by: Yao Zi <ziyao@disroot.org> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2025-08-20T08:31:34Z

Patch 1: "[v2,1/3] dt-bindings: reset: Scope the compatible to VO subsystem explicitly"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 104.81 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T08:48:47Z

Patch 1: "[v2,1/3] dt-bindings: reset: Scope the compatible to VO subsystem explicitly"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1031.75 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:10:51Z

Patch 1: "[v2,1/3] dt-bindings: reset: Scope the compatible to VO subsystem explicitly"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1322.20 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:11:13Z

Patch 1: "[v2,1/3] dt-bindings: reset: Scope the compatible to VO subsystem explicitly"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.65 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:11:37Z

Patch 1: "[v2,1/3] dt-bindings: reset: Scope the compatible to VO subsystem explicitly"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.92 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:11:40Z

Patch 1: "[v2,1/3] dt-bindings: reset: Scope the compatible to VO subsystem explicitly"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.95 seconds
Result: WARNING
Output:

WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#22: 
Reported-by: Icenowy Zheng <uwu@icenowy.me>
Co-developed-by: Michal Wilczynski <m.wilczynski@samsung.com>

total: 0 errors, 1 warnings, 0 checks, 28 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 5d79bb25fd91 ("dt-bindings: reset: Scope the compatible to VO subsystem explicitly") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 28 lines checked
WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report

linux-riscv-bot · 2025-08-20T09:12:56Z

Patch 1: "[v2,1/3] dt-bindings: reset: Scope the compatible to VO subsystem explicitly"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 74.40 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:12:58Z

Patch 1: "[v2,1/3] dt-bindings: reset: Scope the compatible to VO subsystem explicitly"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:13:00Z

Patch 1: "[v2,1/3] dt-bindings: reset: Scope the compatible to VO subsystem explicitly"
kdoc
Desc: Detects for kdoc errors
Duration: 0.91 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:13:02Z

Patch 1: "[v2,1/3] dt-bindings: reset: Scope the compatible to VO subsystem explicitly"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:13:04Z

Patch 1: "[v2,1/3] dt-bindings: reset: Scope the compatible to VO subsystem explicitly"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.27 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:13:06Z

Patch 1: "[v2,1/3] dt-bindings: reset: Scope the compatible to VO subsystem explicitly"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:15:06Z

Patch 2: "[v2,2/3] reset: th1520: Support the new compatible for VO-subsystem controller"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 104.55 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:32:41Z

Patch 2: "[v2,2/3] reset: th1520: Support the new compatible for VO-subsystem controller"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1053.71 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:55:17Z

Patch 2: "[v2,2/3] reset: th1520: Support the new compatible for VO-subsystem controller"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1354.17 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:55:39Z

Patch 2: "[v2,2/3] reset: th1520: Support the new compatible for VO-subsystem controller"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.78 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:56:02Z

Patch 2: "[v2,2/3] reset: th1520: Support the new compatible for VO-subsystem controller"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.56 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:56:06Z

Patch 2: "[v2,2/3] reset: th1520: Support the new compatible for VO-subsystem controller"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.66 seconds
Result: WARNING
Output:

WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#16: 
Reported-by: Icenowy Zheng <uwu@icenowy.me>
Co-developed-by: Michal Wilczynski <m.wilczynski@samsung.com>

total: 0 errors, 1 warnings, 0 checks, 7 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 87c3c11f61d2 ("reset: th1520: Support the new compatible for VO-subsystem controller") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 7 lines checked
WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report

linux-riscv-bot · 2025-08-20T09:57:22Z

Patch 2: "[v2,2/3] reset: th1520: Support the new compatible for VO-subsystem controller"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 74.64 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:57:23Z

Patch 2: "[v2,2/3] reset: th1520: Support the new compatible for VO-subsystem controller"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:57:29Z

Patch 2: "[v2,2/3] reset: th1520: Support the new compatible for VO-subsystem controller"
kdoc
Desc: Detects for kdoc errors
Duration: 4.42 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:57:31Z

Patch 2: "[v2,2/3] reset: th1520: Support the new compatible for VO-subsystem controller"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:57:33Z

Patch 2: "[v2,2/3] reset: th1520: Support the new compatible for VO-subsystem controller"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.26 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:57:35Z

Patch 2: "[v2,2/3] reset: th1520: Support the new compatible for VO-subsystem controller"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T09:59:33Z

Patch 3: "[v2,3/3] riscv: dts: thead: Scope the reset controller to VO for TH1520"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 103.44 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T10:17:41Z

Patch 3: "[v2,3/3] riscv: dts: thead: Scope the reset controller to VO for TH1520"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1086.23 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T10:40:53Z

Patch 3: "[v2,3/3] riscv: dts: thead: Scope the reset controller to VO for TH1520"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1390.88 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T10:41:15Z

Patch 3: "[v2,3/3] riscv: dts: thead: Scope the reset controller to VO for TH1520"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.81 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T10:41:39Z

Patch 3: "[v2,3/3] riscv: dts: thead: Scope the reset controller to VO for TH1520"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.08 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T10:41:42Z

Patch 3: "[v2,3/3] riscv: dts: thead: Scope the reset controller to VO for TH1520"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.59 seconds
Result: WARNING
Output:

WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#17: 
Reported-by: Icenowy Zheng <uwu@icenowy.me>
Co-developed-by: Michal Wilczynski <m.wilczynski@samsung.com>

total: 0 errors, 1 warnings, 0 checks, 18 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 19659672afa9 ("riscv: dts: thead: Scope the reset controller to VO for TH1520") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 18 lines checked
WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report

linux-riscv-bot · 2025-08-20T10:42:58Z

Patch 3: "[v2,3/3] riscv: dts: thead: Scope the reset controller to VO for TH1520"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 74.56 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T10:42:59Z

Patch 3: "[v2,3/3] riscv: dts: thead: Scope the reset controller to VO for TH1520"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T10:43:02Z

Patch 3: "[v2,3/3] riscv: dts: thead: Scope the reset controller to VO for TH1520"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T10:43:04Z

Patch 3: "[v2,3/3] riscv: dts: thead: Scope the reset controller to VO for TH1520"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T10:43:06Z

Patch 3: "[v2,3/3] riscv: dts: thead: Scope the reset controller to VO for TH1520"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.27 seconds
Result: PASS

linux-riscv-bot · 2025-08-20T10:43:07Z

Patch 3: "[v2,3/3] riscv: dts: thead: Scope the reset controller to VO for TH1520"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

ziyao233 added 3 commits August 20, 2025 08:26

linux-riscv-bot closed this Aug 20, 2025

linux-riscv-bot deleted the pw993336 branch August 20, 2025 13:53

Uh oh!

Conversation

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

linux-riscv-bot commented Aug 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects