Skip to content

[PW_SID:994570] selftests/mm: Add compiler flags and fix found warnings - #823

Closed
linux-riscv-bot wants to merge 8 commits into
workflow__riscv__fixesfrom
pw994570
Closed

[PW_SID:994570] selftests/mm: Add compiler flags and fix found warnings#823
linux-riscv-bot wants to merge 8 commits into
workflow__riscv__fixesfrom
pw994570

Conversation

@linux-riscv-bot

@linux-riscv-bot linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown

PR for series 994570 applied to workflow__riscv__fixes

Name: selftests/mm: Add compiler flags and fix found warnings
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=994570
Version: 3

Muhammad Usama Anjum added 8 commits August 22, 2025 15:44
Muhammad Usama Anjum Linux RISC-V bot
selftests/mm: Add -Wunreachable-code and fix warnings
86e9749 
Enable -Wunreachable-code flag to catch dead code and fix them.

1. Remove the dead code and write a comment instead:
hmm-tests.c:2033:3: warning: code will never be executed
[-Wunreachable-code]
                perror("Should not reach this\n");
                ^~~~~~

2. ksft_exit_fail_msg() calls exit(). Remove the dead code.
split_huge_page_test.c:301:3: warning: code will never be executed
[-Wunreachable-code]
                goto cleanup;
                ^~~~~~~~~~~~

3. Remove duplicate inline.
pkey_sighandler_tests.c:44:15: warning: duplicate 'inline' declaration
specifier [-Wduplicate-decl-specifier]
static inline __always_inline

Reviewed-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Muhammad Usama Anjum Linux RISC-V bot
selftests/mm: protection_keys: Fix dead code
248eb08 
The while loop doesn't execute and following warning gets generated:

protection_keys.c:561:15: warning: code will never be executed
[-Wunreachable-code]
                int rpkey = alloc_random_pkey();

Let's enable the while loop such that it gets executed nr_iterations
times. Simplify the code a bit as well.

Reviewed-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Muhammad Usama Anjum Linux RISC-V bot
selftests: kselftest.h: Add unused macro
f44bccd 
Add unused macro instead of using the complete verbose unused compiler
attribute. The raw __attribute__((__unused__)) is quite long and makes
code too much verbose to the kernel developer's taste.

Add always_unused and maybe_unused variants just like kernel itself
have.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Muhammad Usama Anjum Linux RISC-V bot
selftests/mm: Add -Wunused family of flags
74e773e 
Add -Wunused flags and fix all the warnings coming because of
argc and argv. Remove them if they aren't being used entirely. Use
unused compiler attribute with argc where argv is being used.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Muhammad Usama Anjum Linux RISC-V bot
selftests/mm: Remove unused parameters
4d042af 
Cleanup code and remove the unused arguments

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Muhammad Usama Anjum Linux RISC-V bot
selftests/mm: Fix unused parameter warnings for different architectures
b288edc 
There are functions which have unused arguments for different
architectures. Separate the code for each architecture and move #ifdef
arch outside these functions.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Muhammad Usama Anjum Linux RISC-V bot
selftests/mm: mark variable unused with macro
61a1322 
Use __always_unused macro instead of raw compiler attribute.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Muhammad Usama Anjum Linux RISC-V bot
selftests/mm: pkey-helpers: Remove duplicate __maybe_unused
a87388f 
__maybe_unused is now defined in the kselftest.h. Remove from this file
as its not required.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3,1/8] selftests/mm: Add -Wunreachable-code and fix warnings"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 103.70 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3,1/8] selftests/mm: Add -Wunreachable-code and fix warnings"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1026.61 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3,1/8] selftests/mm: Add -Wunreachable-code and fix warnings"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1323.15 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3,1/8] selftests/mm: Add -Wunreachable-code and fix warnings"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.18 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3,1/8] selftests/mm: Add -Wunreachable-code and fix warnings"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.00 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3,1/8] selftests/mm: Add -Wunreachable-code and fix warnings"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.26 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3,1/8] selftests/mm: Add -Wunreachable-code and fix warnings"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 74.86 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3,1/8] selftests/mm: Add -Wunreachable-code and fix warnings"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3,1/8] selftests/mm: Add -Wunreachable-code and fix warnings"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3,1/8] selftests/mm: Add -Wunreachable-code and fix warnings"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3,1/8] selftests/mm: Add -Wunreachable-code and fix warnings"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 1: "[v3,1/8] selftests/mm: Add -Wunreachable-code and fix warnings"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v3,2/8] selftests/mm: protection_keys: Fix dead code"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 103.02 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v3,2/8] selftests/mm: protection_keys: Fix dead code"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1027.26 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v3,2/8] selftests/mm: protection_keys: Fix dead code"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1326.37 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v3,2/8] selftests/mm: protection_keys: Fix dead code"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.91 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v3,2/8] selftests/mm: protection_keys: Fix dead code"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.95 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v3,2/8] selftests/mm: protection_keys: Fix dead code"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.81 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v3,2/8] selftests/mm: protection_keys: Fix dead code"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 77.49 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v3,2/8] selftests/mm: protection_keys: Fix dead code"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v3,2/8] selftests/mm: protection_keys: Fix dead code"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 2: "[v3,2/8] selftests/mm: protection_keys: Fix dead code"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 6: "[v3,6/8] selftests/mm: Fix unused parameter warnings for different architectures"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 74.54 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 6: "[v3,6/8] selftests/mm: Fix unused parameter warnings for different architectures"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 6: "[v3,6/8] selftests/mm: Fix unused parameter warnings for different architectures"
kdoc
Desc: Detects for kdoc errors
Duration: 0.90 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 6: "[v3,6/8] selftests/mm: Fix unused parameter warnings for different architectures"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 6: "[v3,6/8] selftests/mm: Fix unused parameter warnings for different architectures"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 6: "[v3,6/8] selftests/mm: Fix unused parameter warnings for different architectures"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 7: "[v3,7/8] selftests/mm: mark variable unused with macro"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 104.61 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 7: "[v3,7/8] selftests/mm: mark variable unused with macro"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1030.02 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 7: "[v3,7/8] selftests/mm: mark variable unused with macro"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1326.77 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 7: "[v3,7/8] selftests/mm: mark variable unused with macro"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.77 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 7: "[v3,7/8] selftests/mm: mark variable unused with macro"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.30 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 7: "[v3,7/8] selftests/mm: mark variable unused with macro"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.73 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 7: "[v3,7/8] selftests/mm: mark variable unused with macro"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 74.49 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 7: "[v3,7/8] selftests/mm: mark variable unused with macro"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 7: "[v3,7/8] selftests/mm: mark variable unused with macro"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 7: "[v3,7/8] selftests/mm: mark variable unused with macro"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 7: "[v3,7/8] selftests/mm: mark variable unused with macro"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 7: "[v3,7/8] selftests/mm: mark variable unused with macro"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 8: "[v3,8/8] selftests/mm: pkey-helpers: Remove duplicate __maybe_unused"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 104.40 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 8: "[v3,8/8] selftests/mm: pkey-helpers: Remove duplicate __maybe_unused"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1027.91 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 8: "[v3,8/8] selftests/mm: pkey-helpers: Remove duplicate __maybe_unused"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1321.97 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 8: "[v3,8/8] selftests/mm: pkey-helpers: Remove duplicate __maybe_unused"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.26 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 8: "[v3,8/8] selftests/mm: pkey-helpers: Remove duplicate __maybe_unused"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.58 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 8: "[v3,8/8] selftests/mm: pkey-helpers: Remove duplicate __maybe_unused"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.69 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 8: "[v3,8/8] selftests/mm: pkey-helpers: Remove duplicate __maybe_unused"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 74.49 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 8: "[v3,8/8] selftests/mm: pkey-helpers: Remove duplicate __maybe_unused"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 8: "[v3,8/8] selftests/mm: pkey-helpers: Remove duplicate __maybe_unused"
kdoc
Desc: Detects for kdoc errors
Duration: 0.85 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 8: "[v3,8/8] selftests/mm: pkey-helpers: Remove duplicate __maybe_unused"
module-param
Desc: Detect module_param changes
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 8: "[v3,8/8] selftests/mm: pkey-helpers: Remove duplicate __maybe_unused"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 22, 2025

Copy link
Copy Markdown
Author

Patch 8: "[v3,8/8] selftests/mm: pkey-helpers: Remove duplicate __maybe_unused"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@linux-riscv-bot