[PW_SID:995511] vdso: Various cleanups by linux-riscv-bot · Pull Request #837 · linux-riscv/linux

linux-riscv-bot · 2025-08-26T08:24:56Z

PR for series 995511 applied to workflow__riscv__fixes

Name: vdso: Various cleanups
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=995511
Version: 1

When the generic vDSO does not provide time functions, as for example on riscv32, then the time data store is not necessary. Avoid allocating these time data pages when not used. Fixes: df7fcbe ("vdso: Add generic time data storage") Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

The cntvct_ok variable has not had any external user since commit c7a1810 ("lib/vdso: Avoid highres update if clocksource is not VDSO capable"). It also only has one user in vdso.c, once during init, so rather than having the caller of patch_vdso() initialize cntvct_ok, just call cntvct_functional() directly and avoid the global variable entirely. Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

The ENABLE_COMAPT_VDSO symbol is only used by arm64 and only for the time-related functionality. There should be no new users, so it doesn't need to be in the generic vDSO code. Move the logic into arm64 architecture-specific code and replace the explicit define by the standard '#ifdef __aarch64__'. Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

All calls of these functions are already gated behind CONFIG_TIME_NS. The compiler will already optimize them away if time namespaces are disabled. Drop the unnecessary stubs. Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

The generic vDSO can be used without the time-related functionality. In that case the generic update_vsyscall() from kernel/time/vsyscall.c should not be built. Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

On riscv32 the generic vDSO infrastructure is used but without its time-related functionality. The kconfig logic to implement this treats HAVE_GENERIC_VDSO as a synonym for GENERIC_GETTIMEOFDAY. This works today due to some underlying issues in how the generic vDSO library works. Some future cleanups will break this logic. Restructure the kconfig logic, so HAVE_GENERIC_VDSO refers to the generic library in general and GENERIC_GETTIMEOFDAY refers to its time-related functionality. Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

This configuration is never used. Remove it. Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

All users of the generic vDSO library also use the generic vDSO datastore. Remove the now unnecessary kconfig symbol. Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

All architectures implementing time-related functionality in the vDSO are using the generic vDSO library which handles time namespaces properly. Remove the now unnecessary kconfig symbol. Enables the use of time namespaces on architectures, which use the generic vDSO but did not enable GENERIC_VDSO_TIME_NS, namely MIPS and arm. Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

All architectures which want to implement getrandom() in the vDSO need to use the generic vDSO library. Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2025-08-26T08:30:27Z

Patch 1: "[01/11] vdso/datastore: Gate time data behind CONFIG_GENERIC_GETTIMEOFDAY"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 102.77 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T08:48:55Z

Patch 1: "[01/11] vdso/datastore: Gate time data behind CONFIG_GENERIC_GETTIMEOFDAY"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1106.58 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T09:15:02Z

Patch 1: "[01/11] vdso/datastore: Gate time data behind CONFIG_GENERIC_GETTIMEOFDAY"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1565.53 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T09:15:25Z

Patch 1: "[01/11] vdso/datastore: Gate time data behind CONFIG_GENERIC_GETTIMEOFDAY"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 21.02 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T09:15:48Z

Patch 1: "[01/11] vdso/datastore: Gate time data behind CONFIG_GENERIC_GETTIMEOFDAY"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.97 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T09:15:50Z

Patch 1: "[01/11] vdso/datastore: Gate time data behind CONFIG_GENERIC_GETTIMEOFDAY"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.77 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T09:17:07Z

Patch 1: "[01/11] vdso/datastore: Gate time data behind CONFIG_GENERIC_GETTIMEOFDAY"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 74.70 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T09:17:09Z

Patch 1: "[01/11] vdso/datastore: Gate time data behind CONFIG_GENERIC_GETTIMEOFDAY"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T09:17:11Z

Patch 1: "[01/11] vdso/datastore: Gate time data behind CONFIG_GENERIC_GETTIMEOFDAY"
kdoc
Desc: Detects for kdoc errors
Duration: 0.86 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T09:17:13Z

Patch 1: "[01/11] vdso/datastore: Gate time data behind CONFIG_GENERIC_GETTIMEOFDAY"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T09:17:15Z

Patch 1: "[01/11] vdso/datastore: Gate time data behind CONFIG_GENERIC_GETTIMEOFDAY"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.28 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T09:17:17Z

Patch 1: "[01/11] vdso/datastore: Gate time data behind CONFIG_GENERIC_GETTIMEOFDAY"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T09:19:13Z

Patch 2: "[02/11] ARM: VDSO: remove cntvct_ok global variable"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 102.62 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T09:36:17Z

Patch 2: "[02/11] ARM: VDSO: remove cntvct_ok global variable"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1021.51 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T09:58:16Z

Patch 2: "[02/11] ARM: VDSO: remove cntvct_ok global variable"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1318.30 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T09:58:39Z

Patch 2: "[02/11] ARM: VDSO: remove cntvct_ok global variable"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.66 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T09:59:02Z

Patch 2: "[02/11] ARM: VDSO: remove cntvct_ok global variable"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.24 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T09:59:05Z

Patch 2: "[02/11] ARM: VDSO: remove cntvct_ok global variable"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.94 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T10:00:21Z

Patch 2: "[02/11] ARM: VDSO: remove cntvct_ok global variable"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 74.89 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T15:23:29Z

Patch 9: "[09/11] vdso: Drop kconfig GENERIC_VDSO_DATA_STORE"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T15:23:31Z

Patch 9: "[09/11] vdso: Drop kconfig GENERIC_VDSO_DATA_STORE"
module-param
Desc: Detect module_param changes
Duration: 0.32 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T15:23:33Z

Patch 9: "[09/11] vdso: Drop kconfig GENERIC_VDSO_DATA_STORE"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T15:23:35Z

Patch 9: "[09/11] vdso: Drop kconfig GENERIC_VDSO_DATA_STORE"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T15:25:33Z

Patch 10: "[10/11] vdso: Drop kconfig GENERIC_VDSO_TIME_NS"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 103.36 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T15:43:12Z

Patch 10: "[10/11] vdso: Drop kconfig GENERIC_VDSO_TIME_NS"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1057.56 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:05:57Z

Patch 10: "[10/11] vdso: Drop kconfig GENERIC_VDSO_TIME_NS"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1362.95 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:06:19Z

Patch 10: "[10/11] vdso: Drop kconfig GENERIC_VDSO_TIME_NS"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.95 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:06:43Z

Patch 10: "[10/11] vdso: Drop kconfig GENERIC_VDSO_TIME_NS"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 22.14 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:06:47Z

Patch 10: "[10/11] vdso: Drop kconfig GENERIC_VDSO_TIME_NS"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.19 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:08:03Z

Patch 10: "[10/11] vdso: Drop kconfig GENERIC_VDSO_TIME_NS"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 74.15 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:08:05Z

Patch 10: "[10/11] vdso: Drop kconfig GENERIC_VDSO_TIME_NS"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:08:07Z

Patch 10: "[10/11] vdso: Drop kconfig GENERIC_VDSO_TIME_NS"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:08:09Z

Patch 10: "[10/11] vdso: Drop kconfig GENERIC_VDSO_TIME_NS"
module-param
Desc: Detect module_param changes
Duration: 0.28 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:08:11Z

Patch 10: "[10/11] vdso: Drop kconfig GENERIC_VDSO_TIME_NS"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:08:13Z

Patch 10: "[10/11] vdso: Drop kconfig GENERIC_VDSO_TIME_NS"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:10:11Z

Patch 11: "[11/11] vdso: Gate VDSO_GETRANDOM behind HAVE_GENERIC_VDSO"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 103.52 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:27:24Z

Patch 11: "[11/11] vdso: Gate VDSO_GETRANDOM behind HAVE_GENERIC_VDSO"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1031.18 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:49:34Z

Patch 11: "[11/11] vdso: Gate VDSO_GETRANDOM behind HAVE_GENERIC_VDSO"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1329.14 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:49:57Z

Patch 11: "[11/11] vdso: Gate VDSO_GETRANDOM behind HAVE_GENERIC_VDSO"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.89 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:50:20Z

Patch 11: "[11/11] vdso: Gate VDSO_GETRANDOM behind HAVE_GENERIC_VDSO"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.87 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:50:22Z

Patch 11: "[11/11] vdso: Gate VDSO_GETRANDOM behind HAVE_GENERIC_VDSO"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.65 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:51:38Z

Patch 11: "[11/11] vdso: Gate VDSO_GETRANDOM behind HAVE_GENERIC_VDSO"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 74.42 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:51:40Z

Patch 11: "[11/11] vdso: Gate VDSO_GETRANDOM behind HAVE_GENERIC_VDSO"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:51:42Z

Patch 11: "[11/11] vdso: Gate VDSO_GETRANDOM behind HAVE_GENERIC_VDSO"
kdoc
Desc: Detects for kdoc errors
Duration: 0.86 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:51:44Z

Patch 11: "[11/11] vdso: Gate VDSO_GETRANDOM behind HAVE_GENERIC_VDSO"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:51:46Z

Patch 11: "[11/11] vdso: Gate VDSO_GETRANDOM behind HAVE_GENERIC_VDSO"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2025-08-26T16:51:48Z

Patch 11: "[11/11] vdso: Gate VDSO_GETRANDOM behind HAVE_GENERIC_VDSO"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.32 seconds
Result: PASS

t-8ch and others added 11 commits August 26, 2025 08:24

vdso: Drop kconfig GENERIC_VDSO_32

c05a803

This configuration is never used. Remove it. Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

vdso: Drop kconfig GENERIC_COMPAT_VDSO

920301f

This configuration is never used. Remove it. Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

vdso: Gate VDSO_GETRANDOM behind HAVE_GENERIC_VDSO

1bf99a0

All architectures which want to implement getrandom() in the vDSO need to use the generic vDSO library. Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot closed this Sep 3, 2025

linux-riscv-bot deleted the pw995511 branch September 3, 2025 00:59

Uh oh!

Conversation

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!

linux-riscv-bot commented Aug 26, 2025

Uh oh!