Skip to content

[PW_SID:996013] kexec: Fix invalid field access - #841

Closed
linux-riscv-bot wants to merge 3 commits into
workflow__riscv__fixesfrom
pw996013
Closed

[PW_SID:996013] kexec: Fix invalid field access#841
linux-riscv-bot wants to merge 3 commits into
workflow__riscv__fixesfrom
pw996013

Conversation

@linux-riscv-bot

@linux-riscv-bot linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown

PR for series 996013 applied to workflow__riscv__fixes

Name: kexec: Fix invalid field access
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=996013
Version: 1

leitao added 3 commits August 27, 2025 11:41
@leitao Linux RISC-V bot
arm64: kexec: Initialize kexec_buf struct in load_other_segments()
d129562 
The kexec_buf structure was previously declared without initialization.
commit bf454ec ("kexec_file: allow to place kexec_buf randomly")
added a field that is always read but not consistently populated by all
architectures. This un-initialized field will contain garbage.

This is also triggering a UBSAN warning when the uninitialized data was
accessed:

	------------[ cut here ]------------
	UBSAN: invalid-load in ./include/linux/kexec.h:210:10
	load of value 252 is not a valid value for type '_Bool'

Zero-initializing kexec_buf at declaration ensures all fields are
cleanly set, preventing future instances of uninitialized memory being
used.

Signed-off-by: Breno Leitao <leitao@debian.org>
Fixes: bf454ec ("kexec_file: allow to place kexec_buf randomly")
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@leitao Linux RISC-V bot
riscv: kexec: Initialize kexec_buf struct
6cfd2ac 
The kexec_buf structure was previously declared without initialization.
commit bf454ec ("kexec_file: allow to place kexec_buf randomly")
added a field that is always read but not consistently populated by all
architectures. This un-initialized field will contain garbage.

This is also triggering a UBSAN warning when the uninitialized data was
accessed:

	------------[ cut here ]------------
	UBSAN: invalid-load in ./include/linux/kexec.h:210:10
	load of value 252 is not a valid value for type '_Bool'

Zero-initializing kexec_buf at declaration ensures all fields are
cleanly set, preventing future instances of uninitialized memory being
used.

Fixes: bf454ec ("kexec_file: allow to place kexec_buf randomly")
Signed-off-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@leitao Linux RISC-V bot
s390: kexec: Initialize kexec_buf struct
776f2ff 
The kexec_buf structure was previously declared without initialization.
commit bf454ec ("kexec_file: allow to place kexec_buf randomly")
added a field that is always read but not consistently populated by all
architectures. This un-initialized field will contain garbage.

This is also triggering a UBSAN warning when the uninitialized data was
accessed:

	------------[ cut here ]------------
	UBSAN: invalid-load in ./include/linux/kexec.h:210:10
	load of value 252 is not a valid value for type '_Bool'

Zero-initializing kexec_buf at declaration ensures all fields are
cleanly set, preventing future instances of uninitialized memory being
used.

Fixes: bf454ec ("kexec_file: allow to place kexec_buf randomly")
Signed-off-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/3] arm64: kexec: Initialize kexec_buf struct in load_other_segments()"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 104.55 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/3] arm64: kexec: Initialize kexec_buf struct in load_other_segments()"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1027.95 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/3] arm64: kexec: Initialize kexec_buf struct in load_other_segments()"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1318.04 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/3] arm64: kexec: Initialize kexec_buf struct in load_other_segments()"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.90 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/3] arm64: kexec: Initialize kexec_buf struct in load_other_segments()"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.98 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/3] arm64: kexec: Initialize kexec_buf struct in load_other_segments()"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.74 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/3] arm64: kexec: Initialize kexec_buf struct in load_other_segments()"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 73.96 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/3] arm64: kexec: Initialize kexec_buf struct in load_other_segments()"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/3] arm64: kexec: Initialize kexec_buf struct in load_other_segments()"
kdoc
Desc: Detects for kdoc errors
Duration: 2.43 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/3] arm64: kexec: Initialize kexec_buf struct in load_other_segments()"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/3] arm64: kexec: Initialize kexec_buf struct in load_other_segments()"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 1: "[1/3] arm64: kexec: Initialize kexec_buf struct in load_other_segments()"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/3] riscv: kexec: Initialize kexec_buf struct"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 103.85 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/3] riscv: kexec: Initialize kexec_buf struct"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1118.67 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/3] riscv: kexec: Initialize kexec_buf struct"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1562.72 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/3] riscv: kexec: Initialize kexec_buf struct"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.84 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/3] riscv: kexec: Initialize kexec_buf struct"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.78 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/3] riscv: kexec: Initialize kexec_buf struct"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.12 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/3] riscv: kexec: Initialize kexec_buf struct"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 74.94 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/3] riscv: kexec: Initialize kexec_buf struct"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/3] riscv: kexec: Initialize kexec_buf struct"
kdoc
Desc: Detects for kdoc errors
Duration: 0.90 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/3] riscv: kexec: Initialize kexec_buf struct"
module-param
Desc: Detect module_param changes
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/3] riscv: kexec: Initialize kexec_buf struct"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 2: "[2/3] riscv: kexec: Initialize kexec_buf struct"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 3: "[3/3] s390: kexec: Initialize kexec_buf struct"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 104.16 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 3: "[3/3] s390: kexec: Initialize kexec_buf struct"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1027.68 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 3: "[3/3] s390: kexec: Initialize kexec_buf struct"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1329.41 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 3: "[3/3] s390: kexec: Initialize kexec_buf struct"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 20.65 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 3: "[3/3] s390: kexec: Initialize kexec_buf struct"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 21.82 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 3: "[3/3] s390: kexec: Initialize kexec_buf struct"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.68 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 3: "[3/3] s390: kexec: Initialize kexec_buf struct"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 75.73 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 3: "[3/3] s390: kexec: Initialize kexec_buf struct"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 3: "[3/3] s390: kexec: Initialize kexec_buf struct"
kdoc
Desc: Detects for kdoc errors
Duration: 0.87 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 3: "[3/3] s390: kexec: Initialize kexec_buf struct"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 3: "[3/3] s390: kexec: Initialize kexec_buf struct"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot

linux-riscv-bot commented Aug 27, 2025

Copy link
Copy Markdown
Author

Patch 3: "[3/3] s390: kexec: Initialize kexec_buf struct"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
linux-riscv-bot deleted the pw996013 branch September 4, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@linux-riscv-bot @leitao