Skip to content

fix(index): remove redundant setsockopt that shrinks receive buffer #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepin-bot merged 1 commit into from
Oct 15, 2026
Merged

fix(index): remove redundant setsockopt that shrinks receive buffer #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/index/fsmonitor/vfsmonitorwatcher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,12 +601,11 @@ int VfsMonitorFileSystemWatcherPrivate::connectDispatcherSocket()
return -1;
}

// Enlarge the receive buffer for burst headroom.
constexpr int kReceiveBufSize = 8 << 20;
if (::setsockopt(fd, SOL_SOCKET, SO_RCVBUF, &kReceiveBufSize,
sizeof(kReceiveBufSize)) < 0) {
qDebug() << "VfsMonitor: setsockopt(SO_RCVBUF) failed:" << std::strerror(errno);
}
// The dispatcher already sets the receive buffer via SO_RCVBUFFORCE
// (with SO_RCVBUF fallback) on the socketpair fd before passing it
// through D-Bus. Re-issuing SO_RCVBUF here would override that with
// a value capped by rmem_max, potentially *shrinking* the buffer on
// systems where rmem_max < 8 MiB.

return fd;
}
Expand Down
Loading