Repository navigation
feat: adapt deepin-debug-config for dynamic log level control (1/3) - #538
Conversation
Convert plain qDebug/qInfo/qWarning to categorized qCDebug/qCInfo/qCWarning with org.deepin.camera category in core files, register log_rules DConfig listening before application creation, and add dconfig meta org.deepin.camera.json. 将核心文件的普通日志宏改为带 org.deepin.camera 分类的 qCDebug/qCInfo/qCWarning, 注册 log_rules DConfig 监听,新增 dconfig 元数据文件。 Log: 适配deepin-debug-config调试模式(1/3) Influence: 可通过deepin-debug-config动态切换deepin-camera的日志输出级别
Reviewer's GuideThis first split PR adapts the core logging paths to the Sequence diagram for runtime log level configurationsequenceDiagram
participant App as deepin-camera
participant DConfig
participant Env as Environment
participant Logger as DDLog
App->>DConfig: Register org.deepin.camera log_rules
alt DConfig is available
DConfig-->>App: valueChanged
App->>Logger: Update log rules
else DConfig is unavailable
App->>Env: Read log rule fallback
Env-->>App: Log rules
App->>Logger: Update log rules
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: ['建议确认 ddlog.h 头文件已在项目中定义 appLog 日志类别(QLoggingCategory),确保编译通过。'] 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: ['可考虑在后续提交中将 using namespace DDLog; 替换为显式限定 DDLog::appLog,以减少命名空间污染风险。'] 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: [] 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: [] 💡 改进建议代码示例本报告由 AI 代码审查工具自动生成 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: unstable) |
概要 / Summary
适配 deepin-debug-config 调试模式(第 1 部分,共 3 部分,按每 10 个文件拆分提交)。
qDebug()/qInfo()/qWarning()调用转换为qCDebug/qCInfo/qCWarning(appLog),统一使用org.deepin.camera分类,并补充ddlog.h头文件引入;注释代码保持原样logconfigread.cpp在应用实例创建前注册 DConfig(org.deepin.camera,键log_rules)并监听valueChanged,运行中实时切换级别;DConfig 不可用时回退环境变量src/assets/org.deepin.camera.json(键log_rules),旧org.deepin.camera.encode.json移除废弃rules键,src/CMakeLists.txt同步安装两个元数据注:本 PR 为拆分提交的第 1 部分,与第 2、3 部分配合使用;单独合入不影响其余部分后续合入,完整功能三部分合入后生效(完整改动已整体验证:Qt6 Release 构建通过、四档日志级别实测生效)。
Summary by Sourcery
Introduce categorized application logging and DConfig metadata as the first step toward dynamic runtime log-level control for deepin-camera.
New Features:
Enhancements:
Build:
Chores: