Skip to content

fix: restore DTK font token for save confirm dialog - #420

Open
JWWTSL wants to merge 1 commit into
linuxdeepin:masterfrom
JWWTSL:agent/pms-bug-bot/121bb26d0c42
Open

JWWTSL wants to merge 1 commit into
linuxdeepin:masterfrom
JWWTSL:agent/pms-bug-bot/121bb26d0c42

Conversation

@JWWTSL

@JWWTSL JWWTSL commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

fix: restore DTK font token for save confirm dialog

  1. Root cause: commit 8ce3710 split DTK fontManager.t5 into
    font.family + hardcoded font.pixelSize: 16, breaking system
    font scaling for the main message and button text
  2. Fix: restore font: DTK.DTK.fontManager.t5 for the message Label
    and remove hardcoded font.pixelSize/font.weight from buttons
  3. Impact: save confirmation dialog text now follows system font
    size changes, consistent with RemoveDialog.qml DTK convention

Log: 修复保存确认弹窗文字不跟随系统字号变化

Influence:

  1. Test save confirmation dialog with different system font sizes
  2. Verify main message, secondary message and button text all scale
  3. Check no regression on other DTK dialogs

fix: 修复保存确认弹窗文字不跟随系统字号变化

  1. 根因:提交 8ce3710 将 DTK fontManager.t5 拆为 font.family +
    硬编码 font.pixelSize: 16,导致主消息和按钮文字不响应系统字号
  2. 方案:主消息 Label 还原 font: DTK.DTK.fontManager.t5,按钮
    移除 font.pixelSize 和 font.weight 继承 DTK 默认字体
  3. 影响:保存确认弹窗文字恢复跟随系统字号变化,与 RemoveDialog.qml
    的 DTK 规范一致

Log: 修复保存确认弹窗文字不跟随系统字号变化

Influence:

  1. 测试修改系统字号后保存确认弹窗所有文字是否跟随变化
  2. 验证主消息、副消息和按钮文字均正确缩放
  3. 检查其他 DTK 弹窗无回归

PMS: BUG-380081

Summary by Sourcery

Restore DTK-managed typography so all save confirmation dialog text responds correctly to system font-size changes.

Bug Fixes:

  • Restore system font scaling in the save confirmation dialog’s message and action buttons.

Enhancements:

  • Align the save confirmation dialog’s typography with DTK font conventions.

1. Root cause: commit 8ce3710 split DTK fontManager.t5 into
   font.family + hardcoded font.pixelSize: 16, breaking system
   font scaling for the main message and button text
2. Fix: restore font: DTK.DTK.fontManager.t5 for the message Label
   and remove hardcoded font.pixelSize/font.weight from buttons
3. Impact: save confirmation dialog text now follows system font
   size changes, consistent with RemoveDialog.qml DTK convention

Log: 修复保存确认弹窗文字不跟随系统字号变化

Influence:
1. Test save confirmation dialog with different system font sizes
2. Verify main message, secondary message and button text all scale
3. Check no regression on other DTK dialogs

fix: 修复保存确认弹窗文字不跟随系统字号变化

1. 根因:提交 8ce3710 将 DTK fontManager.t5 拆为 font.family +
   硬编码 font.pixelSize: 16,导致主消息和按钮文字不响应系统字号
2. 方案:主消息 Label 还原 font: DTK.DTK.fontManager.t5,按钮
   移除 font.pixelSize 和 font.weight 继承 DTK 默认字体
3. 影响:保存确认弹窗文字恢复跟随系统字号变化,与 RemoveDialog.qml
   的 DTK 规范一致

Log: 修复保存确认弹窗文字不跟随系统字号变化

Influence:
1. 测试修改系统字号后保存确认弹窗所有文字是否跟随变化
2. 验证主消息、副消息和按钮文字均正确缩放
3. 检查其他 DTK 弹窗无回归

PMS: BUG-380081
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JWWTSL

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Restores DTK font-token usage in the save confirmation dialog by applying the managed t5 font to the main message and removing fixed button font overrides, so all dialog text follows system font scaling.

File-Level Changes

Change Details Files
Restored DTK-managed typography for the dialog’s primary message.
  • Replaced manually assembled family, size, and weight properties with the DTK t5 font token.
  • Ensures the message responds to system font scaling consistently with other DTK dialogs.
src/qml/Dialog/EditConfirmDialog.qml
Removed hardcoded button typography so buttons inherit the DTK default font behavior.
  • Deleted fixed pixel size and medium weight overrides from action buttons.
  • Allows button text to scale with system font settings.
src/qml/Dialog/EditConfirmDialog.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 本次提交恢复 DTK 字体 token 的完整使用,将手动设置的 font.family/font.pixelSize/font.weight 替换为 DTK.DTK.fontManager.t5 整体赋值,同时移除按钮上硬编码的字体属性。变更逻辑清晰,语法正确,无安全漏洞,四维度均无问题。

🔍 详细分析

1. 语法逻辑 ✅

评价: 语法正确,逻辑清晰 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


2. 代码质量 ✅

评价: 代码结构清晰,注释完整 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


3. 代码性能 ✅

评价: 性能良好,资源使用合理 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


4. 代码安全 🔒

评价: 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: []


💡 改进建议代码示例

无需修复,当前代码即为最佳实践。使用 DTK 字体 token 整体赋值是推荐做法:
```qml // 推荐写法:使用 DTK 字体 token 整体赋值 font: DTK.DTK.fontManager.t5
// 而非手动拆分设置(不推荐) // font.family: DTK.DTK.fontManager.t5.family // font.pixelSize: 16 // font.weight: Font.Medium ```

本报告由 AI 代码审查工具自动生成

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants