Repository navigation
Conversation
1. Root cause: commit 8ce3710 split DTK fontManager.t5 into font.family + hardcoded font.pixelSize: 16, breaking system font scaling for the main message and button text 2. Fix: restore font: DTK.DTK.fontManager.t5 for the message Label and remove hardcoded font.pixelSize/font.weight from buttons 3. Impact: save confirmation dialog text now follows system font size changes, consistent with RemoveDialog.qml DTK convention Log: 修复保存确认弹窗文字不跟随系统字号变化 Influence: 1. Test save confirmation dialog with different system font sizes 2. Verify main message, secondary message and button text all scale 3. Check no regression on other DTK dialogs fix: 修复保存确认弹窗文字不跟随系统字号变化 1. 根因:提交 8ce3710 将 DTK fontManager.t5 拆为 font.family + 硬编码 font.pixelSize: 16,导致主消息和按钮文字不响应系统字号 2. 方案:主消息 Label 还原 font: DTK.DTK.fontManager.t5,按钮 移除 font.pixelSize 和 font.weight 继承 DTK 默认字体 3. 影响:保存确认弹窗文字恢复跟随系统字号变化,与 RemoveDialog.qml 的 DTK 规范一致 Log: 修复保存确认弹窗文字不跟随系统字号变化 Influence: 1. 测试修改系统字号后保存确认弹窗所有文字是否跟随变化 2. 验证主消息、副消息和按钮文字均正确缩放 3. 检查其他 DTK 弹窗无回归 PMS: BUG-380081
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JWWTSL The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRestores DTK font-token usage in the save confirmation dialog by applying the managed t5 font to the main message and removing fixed button font overrides, so all dialog text follows system font scaling. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: [] 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: [] 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: [] 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: [] 💡 改进建议代码示例无需修复,当前代码即为最佳实践。使用 DTK 字体 token 整体赋值是推荐做法:
```qml // 推荐写法:使用 DTK 字体 token 整体赋值 font: DTK.DTK.fontManager.t5
// 而非手动拆分设置(不推荐) // font.family: DTK.DTK.fontManager.t5.family // font.pixelSize: 16 // font.weight: Font.Medium ```本报告由 AI 代码审查工具自动生成 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: restore DTK font token for save confirm dialog
font.family + hardcoded font.pixelSize: 16, breaking system
font scaling for the main message and button text
and remove hardcoded font.pixelSize/font.weight from buttons
size changes, consistent with RemoveDialog.qml DTK convention
Log: 修复保存确认弹窗文字不跟随系统字号变化
Influence:
fix: 修复保存确认弹窗文字不跟随系统字号变化
硬编码 font.pixelSize: 16,导致主消息和按钮文字不响应系统字号
移除 font.pixelSize 和 font.weight 继承 DTK 默认字体
的 DTK 规范一致
Log: 修复保存确认弹窗文字不跟随系统字号变化
Influence:
PMS: BUG-380081
Summary by Sourcery
Restore DTK-managed typography so all save confirmation dialog text responds correctly to system font-size changes.
Bug Fixes:
Enhancements: