Repository navigation
Conversation
1. Root cause: EditConfirmDialog.qml used hardcoded font.pixelSize on message and button labels, overriding DTK font manager token's adaptive behavior, preventing text from following system font size 2. Fix: restore complete DTK token binding (font: DTK.DTK.fontManager .t5) on message label; remove hardcoded font.pixelSize and font.weight on button label to use DTK.Button default font 3. Impact: save confirmation dialog text now follows system font size changes, consistent with RemoveDialog.qml Log: save confirmation dialog text follows system font size Influence: 1. Test save confirmation dialog with different system font sizes 2. Verify message and button text scale with system font changes 3. Check no regression on dialog layout and appearance fix: 恢复确认对话框的 DTK 字体令牌 1. 根因:EditConfirmDialog.qml 在消息标签和按钮标签上使用硬编码 font.pixelSize,覆盖了 DTK 字体管理器令牌的自适应行为, 导致文字无法跟随系统字号变化 2. 方案:消息标签恢复完整 DTK 令牌绑定(font: DTK.DTK.fontManager .t5);按钮标签删除硬编码 font.pixelSize 和 font.weight, 使用 DTK.Button 默认字体行为 3. 影响:保存确认对话框文字现在跟随系统字号变化,与 RemoveDialog.qml 写法一致 Log: 保存确认对话框文字跟随系统字号变化 Influence: 1. 测试不同系统字号下保存确认对话框的文字显示 2. 验证消息和按钮文字随系统字号变化而缩放 3. 检查对话框布局和外观无回归 PMS: BUG-380081
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JWWTSL The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the save confirmation dialog to use DTK-managed typography for both the message and buttons, restoring system font-size scaling while leaving dialog layout and behavior unchanged. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: 无 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: 无 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: 无 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: 无 💡 改进建议代码示例当前代码已是最佳实践,使用 DTK 设计令牌替代硬编码字体属性,无需额外修复。本报告由 AI 代码审查工具自动生成 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: restore DTK font token in confirm dialog
on message and button labels, overriding DTK font manager token's
adaptive behavior, preventing text from following system font size
.t5) on message label; remove hardcoded font.pixelSize and
font.weight on button label to use DTK.Button default font
size changes, consistent with RemoveDialog.qml
Log: save confirmation dialog text follows system font size
Influence:
fix: 恢复确认对话框的 DTK 字体令牌
font.pixelSize,覆盖了 DTK 字体管理器令牌的自适应行为,
导致文字无法跟随系统字号变化
.t5);按钮标签删除硬编码 font.pixelSize 和 font.weight,
使用 DTK.Button 默认字体行为
RemoveDialog.qml 写法一致
Log: 保存确认对话框文字跟随系统字号变化
Influence:
PMS: BUG-380081
Summary by Sourcery
Bug Fixes: