Skip to content

fix: restore DTK font token in confirm dialog - #423

Open
JWWTSL wants to merge 1 commit into
linuxdeepin:masterfrom
JWWTSL:agent/pms-bug-bot/a3827b755c4f
Open

JWWTSL wants to merge 1 commit into
linuxdeepin:masterfrom
JWWTSL:agent/pms-bug-bot/a3827b755c4f

Conversation

@JWWTSL

@JWWTSL JWWTSL commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

fix: restore DTK font token in confirm dialog

  1. Root cause: EditConfirmDialog.qml used hardcoded font.pixelSize
    on message and button labels, overriding DTK font manager token's
    adaptive behavior, preventing text from following system font size
  2. Fix: restore complete DTK token binding (font: DTK.DTK.fontManager
    .t5) on message label; remove hardcoded font.pixelSize and
    font.weight on button label to use DTK.Button default font
  3. Impact: save confirmation dialog text now follows system font
    size changes, consistent with RemoveDialog.qml

Log: save confirmation dialog text follows system font size

Influence:

  1. Test save confirmation dialog with different system font sizes
  2. Verify message and button text scale with system font changes
  3. Check no regression on dialog layout and appearance

fix: 恢复确认对话框的 DTK 字体令牌

  1. 根因:EditConfirmDialog.qml 在消息标签和按钮标签上使用硬编码
    font.pixelSize,覆盖了 DTK 字体管理器令牌的自适应行为,
    导致文字无法跟随系统字号变化
  2. 方案:消息标签恢复完整 DTK 令牌绑定(font: DTK.DTK.fontManager
    .t5);按钮标签删除硬编码 font.pixelSize 和 font.weight,
    使用 DTK.Button 默认字体行为
  3. 影响:保存确认对话框文字现在跟随系统字号变化,与
    RemoveDialog.qml 写法一致

Log: 保存确认对话框文字跟随系统字号变化

Influence:

  1. 测试不同系统字号下保存确认对话框的文字显示
  2. 验证消息和按钮文字随系统字号变化而缩放
  3. 检查对话框布局和外观无回归

PMS: BUG-380081

Summary by Sourcery

Bug Fixes:

  • Restore adaptive DTK font behavior in the edit confirmation dialog so its message and action labels follow system font-size changes.

1. Root cause: EditConfirmDialog.qml used hardcoded font.pixelSize
   on message and button labels, overriding DTK font manager token's
   adaptive behavior, preventing text from following system font size
2. Fix: restore complete DTK token binding (font: DTK.DTK.fontManager
   .t5) on message label; remove hardcoded font.pixelSize and
   font.weight on button label to use DTK.Button default font
3. Impact: save confirmation dialog text now follows system font
   size changes, consistent with RemoveDialog.qml

Log: save confirmation dialog text follows system font size

Influence:
1. Test save confirmation dialog with different system font sizes
2. Verify message and button text scale with system font changes
3. Check no regression on dialog layout and appearance

fix: 恢复确认对话框的 DTK 字体令牌

1. 根因:EditConfirmDialog.qml 在消息标签和按钮标签上使用硬编码
   font.pixelSize,覆盖了 DTK 字体管理器令牌的自适应行为,
   导致文字无法跟随系统字号变化
2. 方案:消息标签恢复完整 DTK 令牌绑定(font: DTK.DTK.fontManager
   .t5);按钮标签删除硬编码 font.pixelSize 和 font.weight,
   使用 DTK.Button 默认字体行为
3. 影响:保存确认对话框文字现在跟随系统字号变化,与
   RemoveDialog.qml 写法一致

Log: 保存确认对话框文字跟随系统字号变化

Influence:
1. 测试不同系统字号下保存确认对话框的文字显示
2. 验证消息和按钮文字随系统字号变化而缩放
3. 检查对话框布局和外观无回归

PMS: BUG-380081
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JWWTSL

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the save confirmation dialog to use DTK-managed typography for both the message and buttons, restoring system font-size scaling while leaving dialog layout and behavior unchanged.

File-Level Changes

Change Details Files
Restore adaptive DTK font-token behavior for the confirmation dialog message.
  • Replace individual family, size, and weight overrides with the complete DTK.DTK.fontManager.t5 binding.
  • Ensure the message text inherits system font-size adaptations consistently with the remove dialog.
src/qml/Dialog/EditConfirmDialog.qml
Allow confirmation dialog buttons to use the default DTK button typography.
  • Remove hardcoded button font size and weight overrides.
  • Retain existing button layout, highlighting, and text behavior.
src/qml/Dialog/EditConfirmDialog.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 本次提交将确认对话框中的字体属性从手动设置 family/pixelSize/weight 改为直接使用 DTK 字体令牌 fontManager.t5,并移除了按钮上多余的硬编码字体属性。变更简洁、目的明确,无语法、质量、性能或安全问题。

🔍 详细分析

1. 语法逻辑 ✅

评价: 语法正确,逻辑清晰 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 无


2. 代码质量 ✅

评价: 代码结构清晰,注释完整 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 无


3. 代码性能 ✅

评价: 性能良好,资源使用合理 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 无


4. 代码安全 🔒

评价: 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: 无


💡 改进建议代码示例

当前代码已是最佳实践,使用 DTK 设计令牌替代硬编码字体属性,无需额外修复。

本报告由 AI 代码审查工具自动生成

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants