Repository navigation
Conversation
1. Root cause: EditConfirmDialog.qml used hardcoded font.pixelSize and font.weight on message label and button label, overriding DTK font manager token auto-scaling, so text ignored system font size 2. Fix: replace hardcoded properties with full DTK token font: DTK.DTK.fontManager.t5 for message label; remove font.pixelSize and font.weight from button to restore DTK.Button default font behavior 3. Impact: dialog title and button text now follow system font size changes, consistent with RemoveDialog.qml, no regression risk Log: Fixed dialog text not following system font size changes Influence: 1. Test system font size change with edit confirm dialog open 2. Verify all dialog text scales with system font setting 3. Compare behavior with RemoveDialog for consistency fix: 恢复编辑确认对话框的 DTK 字体令牌 1. 根因:EditConfirmDialog.qml 中消息标签和按钮标签使用硬编码 font.pixelSize 和 font.weight,覆盖了 DTK 字体管理器令牌的 自适应行为,导致文字不跟随系统字号变化 2. 方案:消息标签替换为完整 DTK 令牌 font: DTK.DTK.fontManager.t5; 按钮标签删除 font.pixelSize 和 font.weight,恢复 DTK.Button 默认字体行为 3. 影响:对话框标题和按钮文字现在跟随系统字号变化,与 RemoveDialog.qml 写法一致,无回归风险 Log: 修复对话框文字不跟随系统字号变化的问题 Influence: 1. 测试修改系统字号后编辑确认对话框文字是否跟随变化 2. 验证对话框内所有文字均随系统字号设置缩放 3. 与 RemoveDialog 对比行为一致性 PMS: BUG-380081
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JWWTSL The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates EditConfirmDialog.qml to use the DTK font-manager token for the message and the default DTK.Button typography for actions, allowing dialog text to follow system font-size settings consistently with RemoveDialog.qml. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: 无 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: 无 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: 无 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: 无 💡 改进建议代码示例无需修改,当前代码已是正确实现。使用 DTK 字体令牌的方式如下: font: DTK.DTK.fontManager.t5本报告由 AI 代码审查工具自动生成 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: restore DTK font token in edit confirm dialog
and font.weight on message label and button label, overriding
DTK font manager token auto-scaling, so text ignored system font size
font: DTK.DTK.fontManager.t5 for message label; remove font.pixelSize
and font.weight from button to restore DTK.Button default font behavior
changes, consistent with RemoveDialog.qml, no regression risk
Log: Fixed dialog text not following system font size changes
Influence:
fix: 恢复编辑确认对话框的 DTK 字体令牌
font.pixelSize 和 font.weight,覆盖了 DTK 字体管理器令牌的
自适应行为,导致文字不跟随系统字号变化
按钮标签删除 font.pixelSize 和 font.weight,恢复 DTK.Button
默认字体行为
RemoveDialog.qml 写法一致,无回归风险
Log: 修复对话框文字不跟随系统字号变化的问题
Influence:
PMS: BUG-380081
Summary by Sourcery
Bug Fixes: