Skip to content

fix: restore DTK font token in edit confirm dialog - #425

Open
JWWTSL wants to merge 1 commit into
linuxdeepin:masterfrom
JWWTSL:agent/bug/52a30be21487
Open

JWWTSL wants to merge 1 commit into
linuxdeepin:masterfrom
JWWTSL:agent/bug/52a30be21487

Conversation

@JWWTSL

@JWWTSL JWWTSL commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

fix: restore DTK font token in edit confirm dialog

  1. Root cause: EditConfirmDialog.qml used hardcoded font.pixelSize
    and font.weight on message label and button label, overriding
    DTK font manager token auto-scaling, so text ignored system font size
  2. Fix: replace hardcoded properties with full DTK token
    font: DTK.DTK.fontManager.t5 for message label; remove font.pixelSize
    and font.weight from button to restore DTK.Button default font behavior
  3. Impact: dialog title and button text now follow system font size
    changes, consistent with RemoveDialog.qml, no regression risk

Log: Fixed dialog text not following system font size changes

Influence:

  1. Test system font size change with edit confirm dialog open
  2. Verify all dialog text scales with system font setting
  3. Compare behavior with RemoveDialog for consistency

fix: 恢复编辑确认对话框的 DTK 字体令牌

  1. 根因:EditConfirmDialog.qml 中消息标签和按钮标签使用硬编码
    font.pixelSize 和 font.weight,覆盖了 DTK 字体管理器令牌的
    自适应行为,导致文字不跟随系统字号变化
  2. 方案:消息标签替换为完整 DTK 令牌 font: DTK.DTK.fontManager.t5;
    按钮标签删除 font.pixelSize 和 font.weight,恢复 DTK.Button
    默认字体行为
  3. 影响:对话框标题和按钮文字现在跟随系统字号变化,与
    RemoveDialog.qml 写法一致,无回归风险

Log: 修复对话框文字不跟随系统字号变化的问题

Influence:

  1. 测试修改系统字号后编辑确认对话框文字是否跟随变化
  2. 验证对话框内所有文字均随系统字号设置缩放
  3. 与 RemoveDialog 对比行为一致性

PMS: BUG-380081

Summary by Sourcery

Bug Fixes:

  • Restore DTK-managed font scaling in the edit confirmation dialog so message and button text follow system font size changes.

1. Root cause: EditConfirmDialog.qml used hardcoded font.pixelSize
   and font.weight on message label and button label, overriding
   DTK font manager token auto-scaling, so text ignored system font size
2. Fix: replace hardcoded properties with full DTK token
   font: DTK.DTK.fontManager.t5 for message label; remove font.pixelSize
   and font.weight from button to restore DTK.Button default font behavior
3. Impact: dialog title and button text now follow system font size
   changes, consistent with RemoveDialog.qml, no regression risk

Log: Fixed dialog text not following system font size changes

Influence:
1. Test system font size change with edit confirm dialog open
2. Verify all dialog text scales with system font setting
3. Compare behavior with RemoveDialog for consistency

fix: 恢复编辑确认对话框的 DTK 字体令牌

1. 根因:EditConfirmDialog.qml 中消息标签和按钮标签使用硬编码
   font.pixelSize 和 font.weight,覆盖了 DTK 字体管理器令牌的
   自适应行为,导致文字不跟随系统字号变化
2. 方案:消息标签替换为完整 DTK 令牌 font: DTK.DTK.fontManager.t5;
   按钮标签删除 font.pixelSize 和 font.weight,恢复 DTK.Button
   默认字体行为
3. 影响:对话框标题和按钮文字现在跟随系统字号变化,与
   RemoveDialog.qml 写法一致,无回归风险

Log: 修复对话框文字不跟随系统字号变化的问题

Influence:
1. 测试修改系统字号后编辑确认对话框文字是否跟随变化
2. 验证对话框内所有文字均随系统字号设置缩放
3. 与 RemoveDialog 对比行为一致性

PMS: BUG-380081
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JWWTSL

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates EditConfirmDialog.qml to use the DTK font-manager token for the message and the default DTK.Button typography for actions, allowing dialog text to follow system font-size settings consistently with RemoveDialog.qml.

File-Level Changes

Change Details Files
Restore DTK-managed typography for the dialog message.
  • Replace hardcoded font family, size, and weight with the complete DTK t5 font token.
  • Ensure message text inherits DTK font-manager scaling for system font-size changes.
src/qml/Dialog/EditConfirmDialog.qml
Restore default DTK button typography.
  • Remove hardcoded button font size and weight.
  • Allow DTK.Button defaults to control action-label rendering and scaling.
src/qml/Dialog/EditConfirmDialog.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 本次提交目的是修复编辑确认对话框中的 DTK 字体令牌,将手动设置的 font.family/pixelSize/weight 替换为统一的 DTK.DTK.fontManager.t5 字体令牌绑定,并移除按钮上多余的手动字号覆盖。 变更范围小且精准,四维度均无问题,无安全漏洞,代码审查通过。

🔍 详细分析

1. 语法逻辑 ✅

评价: 语法正确,逻辑清晰 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 无


2. 代码质量 ✅

评价: 代码结构清晰,注释完整 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 无


3. 代码性能 ✅

评价: 性能良好,资源使用合理 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 无


4. 代码安全 🔒

评价: 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: 无


💡 改进建议代码示例

无需修改,当前代码已是正确实现。使用 DTK 字体令牌的方式如下: font: DTK.DTK.fontManager.t5

本报告由 AI 代码审查工具自动生成

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants