Repository navigation
Conversation
When exiting fullscreen (e.g. after deleting all images), titleRect.animationShow was not reset to true, leaving the title bar at y=-titleHeight (off-screen). Add onVisibleChanged handler to ViewTopTitle.qml so animationShow is reset whenever the title bar becomes visible (i.e. when exiting fullscreen).
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wyu71 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideFixes the fullscreen-exit deadlock by resetting the title bar’s hidden animation state when it becomes visible, allowing the title bar controls to reappear and the image viewer to be closed. Sequence diagram for resetting the title bar after fullscreen exitsequenceDiagram
participant MainStack
participant ViewTopTitle
participant TitleBarControls
MainStack->>ViewTopTitle: visible = true
ViewTopTitle->>ViewTopTitle: onVisibleChanged
ViewTopTitle->>ViewTopTitle: animationShow = true
ViewTopTitle->>ViewTopTitle: onAnimationShowChanged
ViewTopTitle->>TitleBarControls: y = 0
TitleBarControls-->>MainStack: Close and menu controls reachable
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
Author
|
关闭此 PR,因头分支位于上游仓库(违反跨仓库 PR 规范)。将从 fork (wyu71) 重新提交修复方案更新版。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
PMS #381383: 看图全屏删除图片后回到首页无法退出看图窗口
全屏状态下依次删除图片后回到看图首页,标题栏虽 visible=true 但 Y 坐标停在 -titleHeight(屏幕外不可见),关闭按钮和标题栏菜单均不可达,用户无法退出看图窗口。
根因
switchOpenImage()(MainStack.qml)在退出全屏时重置了showFullScreen、window.opacity、fullScreenAnimating,但遗漏了titleRect.animationShow的重置。全屏期间
animationAll()(FullImageView.qml)将titleRect.animationShow设为false,标题栏 Y 坐标滑至-titleHeight。退出全屏后FullImageView被销毁,animationAll()不复存在,animationShow永远不会被重置为true。commit 89b6fb0(PMS BUG-378387)的修复遗漏了此重置点。
修复方案
在
ViewTopTitle.qml增加onVisibleChanged处理器,当标题栏visible变为true(即退出全屏)时,将animationShow重置为true,触发onAnimationShowChanged将y设为0,标题栏滑回正确位置。覆盖所有退出全屏场景,修改最小化。
关联
Summary by Sourcery
Bug Fixes: