Skip to content

fix: reset title bar animationShow in switchOpenImage - #436

Merged
wyu71 merged 1 commit into
linuxdeepin:masterfrom
wyu71:fix/381383-titlebar-animation-reset
Oct 30, 2026
Merged

wyu71 merged 1 commit into
linuxdeepin:masterfrom
wyu71:fix/381383-titlebar-animation-reset

Conversation

@wyu71

@wyu71 wyu71 commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

fix: reset title bar animationShow in switchOpenImage

  1. Root cause: When deleting all images in fullscreen, switchOpenImage()
    sets showFullScreen=false but titleRect.animationShow stays false,
    leaving the title bar at y=-titleHeight (off-screen and invisible)
  2. Fix: Add titleRect.animationShow=true in switchOpenImage() to reset
    the title bar position when returning to the open-image page
  3. Impact: Only affects the delete-all-images fullscreen exit path, no
    change to normal title bar animation behavior

Log: Fix title bar not visible after fullscreen image deletion

Influence:

  1. Test fullscreen delete all images then verify title bar visible
  2. Test normal fullscreen exit and verify title bar animation works
  3. Test open-image page title bar displays correctly

fix: 在 switchOpenImage 中重置标题栏动画状态

  1. 根因:全屏删除所有图片时 switchOpenImage() 设置 showFullScreen=false
    但 titleRect.animationShow 仍为 false,标题栏 Y 坐标停在 -titleHeight
    (屏幕外不可见),导致无法退出窗口
  2. 方案:在 switchOpenImage() 中添加 titleRect.animationShow=true,回到
    打开图片页时重置标题栏位置
  3. 影响:仅影响全屏删除全部图片的退出路径,不影响正常标题栏动画

Log: 修复全屏删除图片后标题栏不可见的问题

Influence:

  1. 测试全屏删除所有图片后标题栏可见
  2. 测试正常退出全屏后标题栏动画正常
  3. 测试打开图片页标题栏正确显示

PMS: BUG-381383

Summary by Sourcery

Bug Fixes:

  • Restore the title bar when returning to the open-image page after deleting all images in fullscreen mode.

1. Root cause: When deleting all images in fullscreen, switchOpenImage()
   sets showFullScreen=false but titleRect.animationShow stays false,
   leaving the title bar at y=-titleHeight (off-screen and invisible)
2. Fix: Add titleRect.animationShow=true in switchOpenImage() to reset
   the title bar position when returning to the open-image page
3. Impact: Only affects the delete-all-images fullscreen exit path, no
   change to normal title bar animation behavior

Log: Fix title bar not visible after fullscreen image deletion

Influence:
1. Test fullscreen delete all images then verify title bar visible
2. Test normal fullscreen exit and verify title bar animation works
3. Test open-image page title bar displays correctly

fix: 在 switchOpenImage 中重置标题栏动画状态

1. 根因:全屏删除所有图片时 switchOpenImage() 设置 showFullScreen=false
   但 titleRect.animationShow 仍为 false,标题栏 Y 坐标停在 -titleHeight
   (屏幕外不可见),导致无法退出窗口
2. 方案:在 switchOpenImage() 中添加 titleRect.animationShow=true,回到
   打开图片页时重置标题栏位置
3. 影响:仅影响全屏删除全部图片的退出路径,不影响正常标题栏动画

Log: 修复全屏删除图片后标题栏不可见的问题

Influence:
1. 测试全屏删除所有图片后标题栏可见
2. 测试正常退出全屏后标题栏动画正常
3. 测试打开图片页标题栏正确显示

PMS: BUG-381383
@sourcery-ai

sourcery-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fixes the fullscreen delete-all-images exit path by restoring the title bar animation state when switchOpenImage() returns to the open-image page, while leaving normal fullscreen title bar behavior unchanged.

Sequence diagram for restoring the title bar after deleting all fullscreen images

sequenceDiagram
    participant User
    participant MainStack
    participant GStatus
    participant titleRect

    User->>MainStack: switchOpenImage()
    MainStack->>GStatus: stackPage = OpenImagePage
    MainStack->>titleRect: animationShow = true
    opt showFullScreen
        MainStack->>GStatus: showFullScreen = false
    end
    MainStack-->>User: Open-image page with visible title bar
Loading

File-Level Changes

Change Details Files
Reset the title bar visibility state when switching back to the open-image page.
  • Set titleRect.animationShow to true in switchOpenImage() before leaving fullscreen if necessary.
  • Preserve the existing fullscreen-state reset and page-navigation behavior.
src/qml/MainStack.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@wyu71
wyu71 marked this pull request as draft October 30, 2026 08:01
@wyu71
wyu71 marked this pull request as ready for review October 30, 2026 09:12
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wyu71

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wyu71
wyu71 merged commit 9dc88e9 into linuxdeepin:master Oct 30, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants