Repository navigation
fix: reset title bar animationShow in switchOpenImage - #436
Merged
wyu71 merged 1 commit intoOct 30, 2026
Merged
Conversation
1. Root cause: When deleting all images in fullscreen, switchOpenImage() sets showFullScreen=false but titleRect.animationShow stays false, leaving the title bar at y=-titleHeight (off-screen and invisible) 2. Fix: Add titleRect.animationShow=true in switchOpenImage() to reset the title bar position when returning to the open-image page 3. Impact: Only affects the delete-all-images fullscreen exit path, no change to normal title bar animation behavior Log: Fix title bar not visible after fullscreen image deletion Influence: 1. Test fullscreen delete all images then verify title bar visible 2. Test normal fullscreen exit and verify title bar animation works 3. Test open-image page title bar displays correctly fix: 在 switchOpenImage 中重置标题栏动画状态 1. 根因:全屏删除所有图片时 switchOpenImage() 设置 showFullScreen=false 但 titleRect.animationShow 仍为 false,标题栏 Y 坐标停在 -titleHeight (屏幕外不可见),导致无法退出窗口 2. 方案:在 switchOpenImage() 中添加 titleRect.animationShow=true,回到 打开图片页时重置标题栏位置 3. 影响:仅影响全屏删除全部图片的退出路径,不影响正常标题栏动画 Log: 修复全屏删除图片后标题栏不可见的问题 Influence: 1. 测试全屏删除所有图片后标题栏可见 2. 测试正常退出全屏后标题栏动画正常 3. 测试打开图片页标题栏正确显示 PMS: BUG-381383
Reviewer's guide (collapsed on small PRs)Reviewer's GuideFixes the fullscreen delete-all-images exit path by restoring the title bar animation state when Sequence diagram for restoring the title bar after deleting all fullscreen imagessequenceDiagram
participant User
participant MainStack
participant GStatus
participant titleRect
User->>MainStack: switchOpenImage()
MainStack->>GStatus: stackPage = OpenImagePage
MainStack->>titleRect: animationShow = true
opt showFullScreen
MainStack->>GStatus: showFullScreen = false
end
MainStack-->>User: Open-image page with visible title bar
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
wyu71
marked this pull request as draft
October 30, 2026 08:01
wyu71
marked this pull request as ready for review
October 30, 2026 09:12
lzwind
approved these changes
Oct 30, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, wyu71 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: reset title bar animationShow in switchOpenImage
sets showFullScreen=false but titleRect.animationShow stays false,
leaving the title bar at y=-titleHeight (off-screen and invisible)
the title bar position when returning to the open-image page
change to normal title bar animation behavior
Log: Fix title bar not visible after fullscreen image deletion
Influence:
fix: 在 switchOpenImage 中重置标题栏动画状态
但 titleRect.animationShow 仍为 false,标题栏 Y 坐标停在 -titleHeight
(屏幕外不可见),导致无法退出窗口
打开图片页时重置标题栏位置
Log: 修复全屏删除图片后标题栏不可见的问题
Influence:
PMS: BUG-381383
Summary by Sourcery
Bug Fixes: