Repository navigation
feat: close Big Picture and quit Steam when going back to the PC - #121
Merged
Merged
Conversation
Big Picture is always closed on restore; Steam is asked to exit with steam.exe -shutdown (never killed) unless a game is running or the new setting is off. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Important
The setting can be ignored at session start, and an unreadable Steam game-state value is treated as permission to shut Steam down. Please address these before merging.
Reviewed changes The review covers the Steam shutdown-on-restore feature, its settings plumbing and tests.
- Restore behavior Closes Big Picture and requests Steam's normal shutdown when the configured launcher is Big Picture and no Steam game is detected.
- User setting Adds a default-on setting to control whether Steam is closed, with localized UI and manual test steps.
- Policy tests Adds platform-independent tests for shutdown decisions and parsing Steam's registered running app ID.
GPT Luna ｜ 𝕏
…estore # Conflicts: # CHANGELOG.en-US.md # CHANGELOG.md
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Re-reviewed the changes since the prior Pullfrog review, including the updates merged at 9585105.
- Preserved the opt-out setting Copied
CloseSteamOnRestoreinto the reconstructed config so the user's preference reaches the runtime state. - Kept Steam open when game state is unknown Distinguished unreadable or malformed
RunningAppIDvalues from a confirmed zero before deciding whether to request shutdown.
GPT Luna ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going back to the PC now always closes Big Picture (steam://close/bigpicture, then WM_CLOSE) and asks Steam to exit normally with
steam.exe -shutdown. Never a kill. Steam is kept when a game is running or when the new setting (Settings → Close Steam when going back to the PC, on by default) is off. Supersedes #45.Build left to CI (Windows only);
dotnet testpasses (172). Real-session checks are in docs/TESTING.md section 3c.🤖 Generated with Claude Code