Repository navigation
revert: remove Nextestudios TV control and stop changes - #125
Merged
Merged
Conversation
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Important
A tray restore can now race an in-progress start and leave the fullscreen frontend running after the displays have been restored.
Reviewed changes This review covers the three commits reverting Android TV control and the fullscreen-frontend stop behavior.
- Android TV control removal — Removes the ADB/Wake-on-LAN service, persisted TV settings, UI, translations, docs, and tests.
- Stop behavior revert — Restores direct setup restoration for stop signals and the previous
RestoreNowAsyncflow.
GPT Luna ｜ 𝕏
| { | ||
| if (_busy || _restoreRequestActive) return; | ||
| _restoreRequestActive = true; | ||
| if (_busy && !Engine.State.IsActive) return; |
Contributor
There was a problem hiding this comment.
Because Engine.Start sets State.IsActive before finishing display setup, this condition lets the tray's always-available restore command run Engine.Stop() concurrently with startup. Startup can then continue after the restore and launch the frontend with the desktop restored.
Technical details
# Restore can race console startup
## Affected sites
- `src/ConsoleMode/ViewModels/MainViewModel.cs:784` — Allows `RestoreNowAsync` through while `_busy` is true as soon as the engine marks itself active.
- `src/ConsoleMode/Services/ConsoleEngine.cs:84` — `Start` sets `State.IsActive` well before it finishes display setup and launches the configured frontend.
- `src/ConsoleMode/Services/TrayService.cs:44` — The tray restore command calls `RestoreNowAsync` directly.
## Required outcome
- Do not run `Engine.Stop()` concurrently with `Engine.Start()`; a restore requested during startup must not leave startup continuing after the desktop has been restored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the recently merged Nextestudios PRs #93 (TV control) and #45 (stop closes front end).
This removes the ADB/Wake-on-LAN TV control implementation and restores the previous stop behavior. The revert preserves later unrelated commits on main.
Validation: 261 unit tests pass; Windows Release x64 build succeeds. The built executable is available at src/ConsoleMode/bin/Release/net8.0-windows10.0.19041.0/win-x64/ConsoleMode.exe.