Repository navigation
fix: preserve Steam in tray and improve console controller settings - #131
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
lippdev
marked this pull request as ready for review
October 3, 2026 15:03
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
ℹ️ Minor suggestion: make Steam window selection deterministic.
Reviewed changes Reviewed Steam restore behavior and the console controller settings and shortcut-editor changes.
- Steam tray behavior Replaces client shutdown with a window-close request while preserving the running-game guard.
- Controller settings Adds a persisted button-symbol layout and revises console settings and shortcut-editor navigation.
gpt-6-luna ｜ 𝕏
| if (processNames.TryGetValue(unchecked((int)processId), out var processName) && | ||
| SteamShutdown.IsClientWindowCandidate(processName, title.ToString(), className.ToString(), NativeWindows.IsWindowVisible(hwnd), hasOwner)) | ||
| { | ||
| target = hwnd; |
Contributor
There was a problem hiding this comment.
When multiple Steam-owned top-level windows match the predicate, this closes whichever EnumWindows returns first, including matches from steamwebhelper; enumeration order does not identify the primary client window. A non-primary match can leave the desktop client visible or close the wrong Steam window, so select or verify the client window before posting WM_CLOSE.
Technical details
# Identify the Steam client window deterministically
## Affected sites
- `src/ConsoleMode/Services/SteamSession.cs:61-77` — stops at the first matching HWND and posts `WM_CLOSE` to it.
- `src/ConsoleMode/Services/SteamShutdown.cs:8-15` — permits candidates from both `steam` and `steamwebhelper` without distinguishing the main client window.
## Required outcome
- Close only the main Steam client window to the tray; do not depend on top-level window enumeration order or close an unrelated Steam-owned window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore-to-PC previously invoked Steam shutdown, which terminated the client. Close the eligible Steam client window instead, preserving the process and the existing running-game guards.
Improve controller settings inside the console/TV interface: group controller options, persist Auto/Xbox/PlayStation button symbols, enlarge shortcut editor cards and actions, and prevent focus from landing on non-action containers.
Validation: Windows x64 build passed (0 errors; existing warnings), 293 unit tests passed, git diff --check passed. Visually checked the running console UI and directional focus between Change, Remove and Back; verified layout persistence. Physical DualShock and actual Steam tray behavior remain manual checks in docs/TESTING.md.