Repository navigation
fix: only ask Steam's own windows to close when going back to the PC - #140
Merged
Merged
Conversation
The engine rebuilt AppConfig field by field for the session and left out FpsOverlay and FpsOverlayLayout, so Start always saw the default style. The copy is now a clone with only the monitor fields swapped. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Big Picture detection accepts any full-screen SDL_app window, so a running SDL game could get the WM_CLOSE meant for Big Picture. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes I reviewed both commits in this PR: preserving the complete app configuration when resolving session monitor names, and limiting fallback Big Picture close requests to Steam-owned windows.
- Preserve session settings
AppConfig.WithMonitorsreplaces resolved monitor fields on a copy, retaining other settings such as the saved FPS overlay configuration. - Filter close targets The fallback
WM_CLOSEis sent only to windows owned bysteamorsteamwebhelper; broad fullscreen SDL detection remains unchanged for session tracking. - Document and test behavior Added regression tests and a manual Windows scenario for fullscreen SDL games, plus changelog entries.
gpt-6-luna ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LaunchService.CloseBigPicturepostsWM_CLOSEto whateverGetBigPictureHandlesreturns, and that accepts any full-screen window of classSDL_app, from any process. A game built on SDL (Source 2 titles, many indies) running borderless full screen can be picked as "Big Picture" and be asked to close when the user goes back to the PC, possibly with unsaved progress.Fix
The close request is only posted to windows owned by
steam/steamwebhelper; anything else is left open and logged. Detection (GetBigPictureHandles) is unchanged on purpose, so session tracking behaves as before.Known side effect: when a full-screen SDL game is what the detection sees,
CloseBigPicturewaits its full 6 s and logs "ainda aberto" before the restore goes on.Verification
SteamShutdown.IsSteamProcess.docs/TESTING.md(Steam on restore section).Stacked on #139 (shares the changelog section); merge that one first.
🤖 Generated with Claude Code