[platform-stm32f4xx]: Implement sdram support - #338
Closed
luka177 wants to merge 1 commit into
Closed
Conversation
Merged
travisg
approved these changes
Jul 23, 2022
travisg
added a commit
that referenced
this pull request
Aug 23, 2026
Add an FMC SDRAM driver for the STM32F42x/43x parts and enable it on the stm32f429i-disco target, which adds its 8MB of external SDRAM as a second novm arena. Salvaged from PR #338, approved in 2022 but never merged. Changes from the original: - only compile sdram.c for the stm32f429 chip. The F40x parts have an FSMC without the SDRAM controller, so the driver does not build there and the PR as posted broke stm32f4-discovery-test. - NOVM_MAX_ARENAS=2 moves to the stm32f429i-disco target, next to the rest of the SDRAM configuration it belongs with, instead of being set for every F4 part. - declare stm_SDRAM_Init() in platform/sdram.h under its real name rather than repeating an extern in init.c. The header had carried a prototype for a differently named function that does not exist. Compile tested on stm32f429i-disco-test and stm32f4-discovery-test, confirming sdram.c is built only for the former. Not runtime tested on hardware. Co-authored-by: Travis Geiselbrecht <geist@foobox.com>
Member
|
Thanks for this, and sorry it sat for so long — it was approved back in 2022 and then never landed. I've merged it as 06b2f87 with your authorship preserved, plus three changes:
Compile tested on Closing this in favour of the merged commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.