Repository navigation
Fix dynacast never pausing video layers on React Native - #2163
Merged
Merged
Conversation
davidliu
requested review from
1egoman,
lukasIO and
xianshijing-lk
as code owners
October 20, 2026 12:53
🦋 Changeset detectedLatest commit: 4a859d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalVideoTrack.startMonitor()returned early when!isWeb(), before it saved the sender's original encodings tothis.encodings. On React Native,setPublishingLayers()then foundthis.encodingsunset and returned without doing anything. Dynacast updates from the SFU were ignored, and every simulcast layer kept sending even when no one was subscribed to it.This PR moves the
isWeb()check below the point where the encodings are saved. React Native now stores them at publish time, so dynacast can pause and resume layers. The stats monitor interval still runs only on web.