Repository navigation
Conversation
Port of livekit/rust-sdks#1537. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 1127368 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
Contributor
size-limit report 📦
|
lukasIO
approved these changes
Oct 21, 2026
Contributor
Author
|
Going to wait for @ladvoc to take a look before I merge this, since he wrote the original rust sdks PR that this ports over. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of livekit/rust-sdks#1537.
When the SFU rejects a republish after a full reconnect, set the local data track's descriptor to
unpublishedinstead of leaving it inrepublishing, and log the rejection error. Adds a test for a rejected republish, ported fromtest_republish_rejected.Note: in JS,
receivedSfuPublishResponsealready removes the descriptor from the map before handling the response. A track whose republish was rejected was therefore already reported as unpublished throughisPublished()andtryPush, and the new test also passes without the change. The change keeps the state handling the same as the Rust SDK.🤖 Generated with Claude Code