Skip to content

Report room ID changes while an egress runs - #1456

Closed
biglittlebigben wants to merge 4 commits into
mainfrom
benjamin/room-id-updates
Closed

biglittlebigben wants to merge 4 commits into
mainfrom
benjamin/room-id-updates

Conversation

@biglittlebigben

Copy link
Copy Markdown
Contributor

Summary

A room's session ID can change while the egress stays connected (a new server session for a live room, a reconnect, a move). Egress now follows it instead of keeping the ID from the request.

  • SDK source: after connecting, reports the room's name and SID (it may differ from the request), then again on every OnRoomSIDChanged. The SDK callback only signals; a single goroutine owned by the source does the reporting.
  • Web source: room composite and template pages log ROOM_INFO:{"name","sid"}; the chromedp listener only stores and signals, and a reporter goroutine forwards it.
  • Controller: onRoomChanged updates Info.RoomId/RoomName and the manifest. While the egress is active or ending it sends a handler update; before that, the activating update carries the room. Replays keep the recorded room.
  • template-sdk (0.2.2): EgressHelper.setRoom logs ROOM_INFO on connect, reconnect, move, and session ID changes, using RoomEvent.RoomSidChanged when the installed livekit-client has it.
  • go.mod pins server-sdk-go to feat(room): report room SID changes with OnRoomSIDChanged server-sdk-go#1038 for OnRoomSIDChanged. RoomSidChanged is added in Add RoomEvent.RoomSidChanged client-sdk-js#2155.

Testing

  • New TestOnRoomChanged and TestWebSourceOnRoomInfo; go test ./pkg/pipeline/... ./pkg/config/... and golangci-lint pass.
  • template-sdk type-checks; exercised against a fake room with and without RoomSidChanged.
  • Integration suite not run.

🤖 Generated with Claude Code

biglittlebigben and others added 2 commits October 16, 2026 16:35
The SDK and web sources report the connected room's name and session ID; the controller updates EgressInfo and the manifest and sends a handler update while active. template-sdk logs ROOM_INFO on changes.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

AV-sync stats summary: view in run #38985309958

biglittlebigben and others added 2 commits October 16, 2026 17:12
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant