Repository navigation
Report room ID changes while an egress runs - #1456
Closed
biglittlebigben wants to merge 4 commits into
Closed
biglittlebigben wants to merge 4 commits into
biglittlebigben wants to merge 4 commits into
Conversation
The SDK and web sources report the connected room's name and session ID; the controller updates EgressInfo and the manifest and sends a handler update while active. template-sdk logs ROOM_INFO on changes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Ref: https://github.com/livekit/egress/tree/1456/merge By: biglittlebigben
Contributor
|
AV-sync stats summary: view in run #38985309958 |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Ref: https://github.com/livekit/egress/tree/1456/merge By: biglittlebigben
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A room's session ID can change while the egress stays connected (a new server session for a live room, a reconnect, a move). Egress now follows it instead of keeping the ID from the request.
OnRoomSIDChanged. The SDK callback only signals; a single goroutine owned by the source does the reporting.ROOM_INFO:{"name","sid"}; the chromedp listener only stores and signals, and a reporter goroutine forwards it.onRoomChangedupdatesInfo.RoomId/RoomNameand the manifest. While the egress is active or ending it sends a handler update; before that, the activating update carries the room. Replays keep the recorded room.EgressHelper.setRoomlogsROOM_INFOon connect, reconnect, move, and session ID changes, usingRoomEvent.RoomSidChangedwhen the installed livekit-client has it.go.modpins server-sdk-go to feat(room): report room SID changes with OnRoomSIDChanged server-sdk-go#1038 forOnRoomSIDChanged.RoomSidChangedis added in Add RoomEvent.RoomSidChanged client-sdk-js#2155.Testing
TestOnRoomChangedandTestWebSourceOnRoomInfo;go test ./pkg/pipeline/... ./pkg/config/...andgolangci-lintpass.RoomSidChanged.🤖 Generated with Claude Code