Skip to content

change emitted TS code to group attribute values under a const object… - #1872

Open
lukasIO wants to merge 1 commit into
blaze/otel-semconv-registryfrom
lukas/ts-gen-const-obj
Open

lukasIO wants to merge 1 commit into
blaze/otel-semconv-registryfrom
lukas/ts-gen-const-obj

Conversation

@lukasIO

@lukasIO lukasIO commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

… definition

@changeset-bot

changeset-bot Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c8e6003

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukasIO
lukasIO requested a review from pblazej October 19, 2026 15:06
@pblazej
pblazej added this pull request to stack #1877 October 20, 2026 11:08
@pblazej
pblazej force-pushed the lukas/ts-gen-const-obj branch from 5dc793e to c8e6003 Compare October 21, 2026 16:06
pblazej added a commit to livekit/agents that referenced this pull request Oct 21, 2026
Move the `protocol` submodule to 8b2aa35d (livekit/protocol#1872), which
groups each attribute's Python values under a class with the TypeScript
const-object name and removes the 141 flat value constants. Regenerate the
Python copy; the Rust copy does not change. The trace_types aliases keep
their names and values and now read the class members, and the pin test
looks up the track source and disconnect reason values the same way. Every
exposed string stays byte-identical.

@pblazej pblazej left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants