Repository navigation
Add livekit/server/sdk entrypoint so Bundler.require loads the gem - #102
Open
corsonknowles wants to merge 1 commit into
Open
corsonknowles wants to merge 1 commit into
corsonknowles wants to merge 1 commit into
Conversation
Bundler.require tries require 'livekit-server-sdk', then 'livekit/server/sdk'. Neither path existed, so the gem was skipped silently unless the Gemfile set require: 'livekit'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With a plain
gem "livekit-server-sdk"line in a Gemfile,Bundler.requiredoes not load this gem, and it does so silently.Bundler's autorequire first tries
require "livekit-server-sdk". When that raises aLoadErrorfor exactly that path and the name contains dashes, it retries with every-replaced by/, i.e.require "livekit/server/sdk". If that also fails, Bundler skips the gem without a warning.The entrypoint here is
livekit, so neither path matches, and consumers have to writegem "livekit-server-sdk", require: "livekit"or add a manualrequire "livekit"somewhere. In a Rails app that relies onBundler.requirethis shows up asuninitialized constant LiveKit::...errors that depend on load order. #75 may be one instance of this: if app code defines something underLiveKit::before the gem is loaded, the autoloader can end up owning theLiveKitnamespace and remove it on reload.Change
lib/livekit/server/sdk.rb, which only doesrequire_relative "../../livekit". It defines no constants, so there is nothing new underLiveKit::Server, and nothing collides with the existinglib/livekit/files or the generated protos.[Unreleased]inCHANGELOG.md. I left the version alone.It's fully backward compatible:
require "livekit"and existingrequire:options keep working unchanged, and requiring both paths loads the code once.spec.filescomes fromgit ls-files, so the file ships in the gem.Verification
With a scratch Gemfile containing only
gem "livekit-server-sdk", path: "<checkout>"(norequire:), runningBundler.require; p defined?(LiveKit::AccessToken):nil"constant"🤖 Generated with Claude Code