-
Notifications
You must be signed in to change notification settings - Fork 35
Fix issues around glibc mis-calculating IE TLS sizes when spindle is running #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a8c0fd7
Add test for TLS issue
mplegendre 92afcac
Fix issue with apps exiting at startup because of insufficient TLS
mplegendre 7142af7
Allow clients to send messages to servers that are more than 4096 bytes.
mplegendre 68e1750
Fix build and configure issues in TLS static calculations
mplegendre 8a6f827
Merge branch 'devel' into bugfix/tls-calc
mplegendre a850bd3
Fix use after free crash in TLS info handling
mplegendre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,3 +35,4 @@ run_driver | |
| run_driver_rm | ||
| preload_file_list | ||
| build | ||
| .vscode | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| #include <pthread.h> | ||
| #include <stdio.h> | ||
|
|
||
| extern void set_bigtls(); | ||
| extern int get_bigtls(); | ||
|
|
||
| void *runthrd(void *name) | ||
| { | ||
| get_bigtls(); | ||
| return NULL; | ||
| } | ||
|
|
||
| int main(int argc, char *argv[]) | ||
| { | ||
| pthread_t thrd; | ||
|
|
||
| pthread_create(&thrd, NULL, runthrd, "thrd"); | ||
| set_bigtls(); | ||
| runthrd("main"); | ||
| pthread_join(thrd, NULL); | ||
| printf("Passed\n"); | ||
| return 0; | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| #define _GNU_SOURCE | ||
| #include <link.h> | ||
|
|
||
| unsigned int la_version(unsigned int v) { | ||
| return v; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| #!/bin/bash | ||
|
|
||
| CC=$1 | ||
| CFLAGS=$2 | ||
| SRCDIR=$3/scripts/static_tls_test | ||
| BINDIR=$4/static_tls_test | ||
|
|
||
| mkdir -p $BINDIR | ||
|
|
||
| if [ ! -f "$BINDIR/statictls" ]; then | ||
| $CC $CFLAGS -o $BINDIR/libstatictls.so -shared -fPIC $SRCDIR/statictls.c | ||
| $CC $CFLAGS -o $BINDIR/statictls -L$BINDIR -Wl,-rpath,$BINDIR $SRCDIR/app.c -lstatictls -lpthread | ||
| $CC $CFLAGS -o $BINDIR/libminaudit.so -fPIC -shared $SRCDIR/minaudit.c | ||
| fi | ||
| LD_AUDIT=$BINDIR/libminaudit.so $BINDIR/statictls >& /dev/null | ||
| RESULT=$? | ||
|
|
||
| exit $RESULT | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| __thread unsigned char bigtls[20000000] __attribute__((tls_model("initial-exec"))); | ||
|
|
||
| void set_bigtls() | ||
| { | ||
| for (unsigned i = 0; i < sizeof(bigtls); i++) { | ||
| bigtls[i] = (unsigned char) i % 255; | ||
| } | ||
| } | ||
|
|
||
| int get_bigtls() | ||
| { | ||
| int result = 0; | ||
| for (unsigned i = 0; i < sizeof(bigtls); i++) { | ||
| result += bigtls[i]; | ||
| } | ||
| return result; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is producing a syntax error when run by configure:
See, for example, the build of the serial image: https://github.com/llnl/Spindle/actions/runs/35164411510/job/105022155537#step:4:1050
I think the problem is the
>& /dev/nullin the previous line. The script specifies#!/bin/shbut that form of redirect is a bash extension.