Repository navigation
Collaborative GitHub Excercise - #429
Conversation
|
Hi Chiara, when you examine your pull request, the parameter sig 2 is missing. Can you make the change locally, save, commit, push, refresh your browser to see if the pull request gets updated? then ping me so I can check and merge it ;) |
|
Hey @MalikaIhle , thank you - I changed it. However I am still getting used to the workflow. How do I ping you - if that is in GitHub? |
|
Your parameters look great thanks ! You did exactly right to ping me. Given we were already in a conversation I get an email notification for your reply. In addition, in my case I'm 'watching' all our repo so get notified of all activities. In the future, some pull request you will merge yourself when you are sure and don't need me to check, others you might want to tag me as a reviewer. We can check that together if you don't find it. I will now merge this PR so you see what happens then. |
I added Chiaras_beluga as part of the excercise of Collaborative working in GitHub