Repository navigation
fix(english/allnovel): return empty list for search pages past the last - #2758
Merged
rajarsheechatterjee merged 1 commit intoOct 24, 2026
Conversation
novelfull.com responds with HTTP 404 for search pages beyond the last one, so the plugin threw 'Could not reach site (404)' when scrolling search results. Treat a 404 on page > 1 as the end of results, and bump AllNovel's version. Closes lnreader#2755 Co-Authored-By: Grok Bot (AI agent) <noreply@x.ai>
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryUpdates
Reviews (1) · Last reviewed commit: "fix(english/allnovel): return empty list..." · Reviewed by Greptile |
rajarsheechatterjee
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2755
What changed
plugins/multisrc/readnovelfull/template.ts: insearchNovels, an HTTP 404 onpage > 1now returns[](end of results) instead of throwing.plugins/multisrc/readnovelfull/sources.json: bump AllNovelversionIncrements1 → 2 (2.3.4 → 2.3.5) so the app picks up the fix.Why
novelfull.com (AllNovel) answers past-the-last-page search URLs with a real 404:
When infinite scroll asked for the next page, the plugin threw
Could not reach site ('404').How it was verified
npm ci: okAllNovel[readnovelfull].tswith esbuild (same config ascheck:plugin, plus a browser User-Agent because Node's fetch gets a 403 without one) and calledsearchNovels('love', 1..4):Could not reach site ('404')0novels (no error)npm run check:plugin -- "plugins/english/AllNovel[readnovelfull].ts":popularNovelsgets a 403 from this host both before and after the change (the site blocks the default Node UA), so this run is inconclusive. That 403 was already there and isn't related to this fix.npm run build:full: passnpx tsc --project tsconfig.production.json --noEmit: passnpx eslint plugins/multisrc/readnovelfull/template.ts: 0 errors. One warning already existed (fetchedPagesunused). Repo-widenpm run lintand plainnpx tsc --noEmitalready fail on master in unrelated files.Risks
Checklist
type(scope): descriptionPartly authored by an AI agent (Grok Bot), please review with that in mind.