Skip to content

fix(english/allnovel): return empty list for search pages past the last - #2758

Merged
rajarsheechatterjee merged 1 commit into
lnreader:masterfrom
Gourab0002:fix/english-allnovel-search-pagination
Oct 24, 2026
Merged

rajarsheechatterjee merged 1 commit into
lnreader:masterfrom
Gourab0002:fix/english-allnovel-search-pagination

Conversation

@Gourab0002

Copy link
Copy Markdown
Contributor

Closes #2755

What changed

  • plugins/multisrc/readnovelfull/template.ts: in searchNovels, an HTTP 404 on page > 1 now returns [] (end of results) instead of throwing.
  • plugins/multisrc/readnovelfull/sources.json: bump AllNovel versionIncrements 1 → 2 (2.3.4 → 2.3.5) so the app picks up the fix.

Why

novelfull.com (AllNovel) answers past-the-last-page search URLs with a real 404:

/search?keyword=love&page=3   200
/search?keyword=love&page=4   404
/search?keyword=xqzv&page=2   404   (one-page result set: this matches the issue, which fails on page 2)

When infinite scroll asked for the next page, the plugin threw Could not reach site ('404').

How it was verified

  • npm ci: ok
  • Live harness: bundled AllNovel[readnovelfull].ts with esbuild (same config as check:plugin, plus a browser User-Agent because Node's fetch gets a 403 without one) and called searchNovels('love', 1..4):
    • before: pages 1–3 return 20/20/10 novels, page 4 throws Could not reach site ('404')
    • after: pages 1–3 return 20/20/10 novels, page 4 returns 0 novels (no error)
  • npm run check:plugin -- "plugins/english/AllNovel[readnovelfull].ts": popularNovels gets a 403 from this host both before and after the change (the site blocks the default Node UA), so this run is inconclusive. That 403 was already there and isn't related to this fix.
  • npm run build:full: pass
  • npx tsc --project tsconfig.production.json --noEmit: pass
  • npx eslint plugins/multisrc/readnovelfull/template.ts: 0 errors. One warning already existed (fetchedPages unused). Repo-wide npm run lint and plain npx tsc --noEmit already fail on master in unrelated files.

Risks

  • The change is in the shared template, so every readnovelfull source now treats a 404 on page > 1 as "no more results". A 404 on page 1 still throws as before. Only AllNovel's version is bumped, so the other sources pick up the change on their next bump.

Checklist

  • Update version code if an existing plugin was modified
  • Test changes in Plugin Playground or the app (live harness against novelfull.com, see above)
  • Reference related issues in the PR body
  • Commit messages follow type(scope): description

Partly authored by an AI agent (Grok Bot), please review with that in mind.

novelfull.com responds with HTTP 404 for search pages beyond the last one, so the plugin threw 'Could not reach site (404)' when scrolling search results. Treat a 404 on page > 1 as the end of results, and bump AllNovel's version.

Closes lnreader#2755

Co-Authored-By: Grok Bot (AI agent) <noreply@x.ai>
@greptile-apps

greptile-apps Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Updates searchNovels to return an empty list when a later search page returns HTTP 404.

  • Later ReadNovelFull search pages return no results on a 404.

Reviews (1) · Last reviewed commit: "fix(english/allnovel): return empty list..." · Reviewed by Greptile

@rajarsheechatterjee
rajarsheechatterjee merged commit b65a508 into lnreader:master Oct 24, 2026
4 checks passed
@Gourab0002
Gourab0002 deleted the fix/english-allnovel-search-pagination branch October 25, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All novel is failing to load the second page on the search list

2 participants