fix: reduce invite nags - #24
Open
nick-bors wants to merge 1 commit into
Open
Conversation
Contributor
Author
pushcx
requested changes
Jul 16, 2026
pushcx
left a comment
pushcx
left a comment
Member
There was a problem hiding this comment.
Thanks for coming back to this. One code tweak to make this a little more resilient and we'll get this deployed.
Member
There was a problem hiding this comment.
I don't want to throw an exception for this control flow, it doesn't feel like there's actually an exceptional situation if someone joined before this was deployed, or joined when the bot was offline for a minute.
And I would rather fail safe. If the bot doesn't know that it has seen someone join in the last 10 minutes, it should fail silently. I would rather it miss giving an invite suggestion or two than give extra.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow on from the now-closed #22 to fix issue #23
I think the
joinedAtkey might become useful in the future too. Its more justified than alastJoined(imo).