Repository navigation
[FSTORE-2122] Improve sharing UI - #684
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new capture does not follow the repository’s page-mirroring asset placement convention.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates the Feature Store sharing guide for the redesigned sharing UI.
Changes:
- Documents sharing visibility, restrictions, and unsharing.
- Refreshes screenshots and accessibility text.
- Marks the sharing page as parity-reviewed.
| File | Description |
|---|---|
docs/user_guides/fs/sharing/sharing.md |
Updates sharing procedures and UI guidance. |
.claude/docs/parity-review.md |
Marks the page reviewed. |
docs/assets/images/guides/project/sharing/share_with_other_projects.png |
Refreshes Projects tab capture. |
docs/assets/images/guides/project/sharing/feature_store_sharing_restricted_users.png |
Adds Restricted users capture. |
docs/assets/images/guides/project/sharing/share_project_dialog.png |
Refreshes Feature Store sharing dialog. |
docs/assets/images/guides/project/sharing/list_of_shared_projects.png |
Removes obsolete capture. |
docs/assets/images/guides/project/sharing/share_feature_group.png |
Refreshes Feature Group sharing view. |
docs/assets/images/guides/project/sharing/share_feature_group_dialog_project.png |
Refreshes project-sharing dialog. |
docs/assets/images/guides/project/sharing/list_of_projects_feature_group_shared_with.png |
Refreshes shared-project list. |
docs/assets/images/guides/project/sharing/share_feature_group_dialog_user.png |
Refreshes restricted-user dialog. |
docs/assets/images/guides/project/sharing/list_of_users_feature_group_shared_with.png |
Refreshes restricted-user list. |
docs/assets/images/guides/project/sharing/using_shared_feature_groups.png |
Refreshes shared Feature Store selector. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
https://hopsworks.atlassian.net/browse/FSTORE-2122 The sharing section of project settings only said whether a project had the whole feature store or part of it. It is now a "Feature store sharing" section that lists every project and restricted user the feature store is shared with, and what each of them can read, with share, unshare and revoke actions in place. Rewrite the sharing guide for that UI: reading the Projects and Restricted users tabs, who sees the section (data owners with the share and unshare actions, observers read-only), the share dialog for the entire feature store and for one feature group, the rule that a project holds the whole store or individual feature groups, and unsharing. All captures are redone on the new UI, scoped to the card or dialog per captures.md; the new Restricted users capture lives under guides/fs/sharing, and the old list-of-shared-projects capture is dropped because the settings capture now shows that list. The Python examples are unchanged. Reviewed-by: GitHub Copilot <Copilot@users.noreply.github.com> Signed-off-by: Ralfs Zangis <ralfs@logicalclocks.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
bubriks
marked this pull request as ready for review
October 6, 2026 11:44
dhananjay-mk
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://hopsworks.atlassian.net/browse/FSTORE-2122
Updates
user_guides/fs/sharing/sharing.mdfor the reworked sharing UI in logicalclocks/hopsworks-front#2144 (backend: logicalclocks/hopsworks-ee#3428).Feature store sharingsection of Project Settings: theProjectstab (entire feature store, or which feature groups and features) and theRestricted userstab..claude/docs/captures.md.feature_store_sharing_restricted_users.pngis new;list_of_shared_projects.pngis removed because the settings capture now shows that list.Checks:
hopsworks-docs markdownlintpasses.hopsworks-docs checkpasses with the current hopsworks-apimaininstalled. Snakeoil reports the same findings on this page as onmain, since the Python blocks are unchanged.🤖 Generated with Claude Code