Repository navigation
Conversation
bbrondel
approved these changes
Oct 16, 2026
| @@ -0,0 +1 @@ | |||
| CMake integration, towncrier. | |||
There was a problem hiding this comment.
The news fragment mentions towncrier, but there doesn't appear to be any work on towncrier in this PR.
| # test_Timestamp.cpp | ||
| # test_simulated_transport.cpp | ||
| # test_version.cpp | ||
| ) |
There was a problem hiding this comment.
It looks like you've started moving tests over but have more to do. Please add a comment explaining why these lines are commented out. Consider writing a Jira ticket and mentioning the ticket in this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiles library. Some tests can be compiled and runs, but majority need extra work.