Repository navigation
Added new wait_for_sun_elevation.py script to sleep the queue until s… - #303
Merged
Merged
Conversation
edennihy
force-pushed
the
tickets/OSW-2467
branch
2 times, most recently
from
July 2, 2026 00:47
1d538c0 to
667122a
Compare
Contributor
Author
|
Tested on BTS on 2026-07-01 |
edennihy
force-pushed
the
tickets/OSW-2467
branch
7 times, most recently
from
July 7, 2026 23:20
c96e090 to
67960cd
Compare
edennihy
force-pushed
the
tickets/OSW-2467
branch
11 times, most recently
from
July 28, 2026 18:47
ac23ad7 to
8cb9db0
Compare
tribeiro
reviewed
Jul 28, 2026
| from .sleep import * | ||
| from .system_wide_shutdown import * | ||
| from .utils import * | ||
| from .wait_for_sun_elevation import * |
Member
There was a problem hiding this comment.
I am not sure this is necessary... I think we can keep here only things that are broadly used, e.g. the base classes. For now I think we can just stop adding things here for now.
| class TestWaitForSunElevation(BaseScriptTestCase, unittest.IsolatedAsyncioTestCase): | ||
| async def basic_make_script(self, index): | ||
| self.script = WaitForSunElevation(index=index) | ||
| self.script.mtcs = MTCS( |
Member
There was a problem hiding this comment.
I just noticed that mtcs is already defined as DryTest in the script. I think you can remove this.
…olar elevation is reached.
…hot.py, scheduler/stop.py.
… resources are properly cleaned up.
edennihy
force-pushed
the
tickets/OSW-2467
branch
from
July 28, 2026 18:58
8cb9db0 to
d5d61e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…olar elevation is reached.