Repository navigation
fix: the site would not build, and its GitHub Pages returned 404 - #78
Merged
Merged
Conversation
Two things, both of which had made this repo look abandoned. - The production build failed in minification. echarts-gl was on ^2.0.0-rc.3, whose ES6 output UglifyJS (webpack 1 era, ES5 only) cannot parse. Pinned back to ^1.1.2, which is also the line matching the echarts@4 this site uses — echarts-gl 2 targets echarts 5. - This repo's Pages was configured to serve the master root, which has no index.html, so https://ludejun.github.io/Deep-Viz-Website/ has always been a 404. The site is now built and published by a workflow. Also - publicPath was hard-coded to /deepviz/, tying every build to one URL. It is now the relative "./", so the same output works at /deepviz/, /Deep-Viz-Website/ or the domain root. Verified by serving the build under a subdirectory and loading the component pages. - pages.yml deploys to GitHub Pages on every push to master, through the official Pages actions and the built-in GITHUB_TOKEN. - ci.yml builds the site on every pull request. - English README_EN.md alongside the Chinese README.md, both with badges and a plain statement of where the stack stands. New CHANGELOG.md. The React 15 + roadhog 0.6 toolchain stays. roadhog stopped in 2019 and was replaced by umi; moving off it means swapping the build system under a 194-file site, which is a rewrite rather than maintenance. roadhog 0.6 also cannot run under pnpm — it resolves its own loaders through a flat node_modules — so this repo stays on npm while the others moved across. Verified: npm run build and npm run lint both pass on Node 22, and the built gallery renders correctly, charts included. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things, both of which had made this repo look abandoned.
The production build failed
echarts-glwas on^2.0.0-rc.3, whose ES6 output UglifyJS (webpack 1 era, ES5 only) cannot parse:Pinned back to
^1.1.2— which is also the line that matches theecharts@4this site uses. echarts-gl 2 targets echarts 5, so the pairing was wrong to begin with.This repo's GitHub Pages was a 404
Pages was set to serve the
masterroot, which has noindex.html, so https://ludejun.github.io/Deep-Viz-Website/ has always returned 404.The background, for the record: https://ludejun.github.io/deepviz/ — the URL Deep-Viz's README and
package.jsonhomepage point at — has always been this repo's build output, copied by hand into a separatedeepvizrepo. This repo, the actual source, published nothing.Now
pages.ymlbuilds and deploys on every push tomaster, through the official Pages actions and the built-inGITHUB_TOKEN.publicPathwas also hard-coded to/deepviz/, tying every build to one URL. It is now the relative./, so one build works at/deepviz/,/Deep-Viz-Website/or the domain root — verified by serving the output under a subdirectory and loading the component pages.Important
After merging, switch this repo's Pages source to the workflow:
Once the site is live here, the hand-copied
deepvizrepo can be retired — or kept and pointed at, your call. Both URLs will serve a working site; only one of them will be automatic.Also
ci.ymlbuilds the site on every pull request, so it cannot rot unnoticed again.README_EN.mdalongside the ChineseREADME.md, both with badges and a plain statement of where the stack stands. NewCHANGELOG.md.What is deliberately not changed
The React 15 + roadhog 0.6 toolchain stays. roadhog stopped in 2019 and was replaced by umi; moving off it means swapping the build system under a 194-file site — a rewrite, not maintenance.
Worth knowing: roadhog 0.6 cannot run under pnpm. It resolves its own loaders through a flat
node_modules(Cannot resolve module 'babel'), so this repo stays on npm while the others in this maintenance round moved across. Both READMEs say so.Verified
npm run buildandnpm run lintpass on Node 22, and the built gallery renders correctly — charts, axes, legends and all.🤖 Generated with Claude Code