Ghost Buster / Configurable Reverse Stop - #97
Open
pbz wants to merge 12 commits into
Open
Conversation
Add step to upload refloat.vescpkg artifact
Owner
|
Hello, this anti-ghosting measure should not be implemented through Reverse Stop at all. The main point of Reverse Stop is to gently put the tail down after a certain distance. For anti-ghosting, you want to ideally give a haptic warning once starting to ride backwards and just shut the motor after some distance / speed. I'd much prefer this was discussed on discord prior to implementation. The PR is against 1.2 and the Reverse Stop was re-written, and the PR is kind of all over the place, it's not really useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is definitely not ready to merge yet, at all, but worked on this for my own use and wanted to see if the Refloat devs were interested, but also to make these changes available for others who might need them.
Anyway, my motivation for this was getting tire of fixing my board after it ghosted and rammed itself into things. It occurred to me that reverse stop was an easy solution to this for the typical tail heavy board, but I like being able to go in reverse, at least a little.
So this pull request just makes reverse stop a bit more configurable, and introduces one tiny change to the logic, you only have to drop below the trigger ERPM to stop accumulating towards the cutoff threshold rather than reverse direction.
I found the following values suitable for a ghost prone board, outdoors to allow enough reversing with gentle warning before the tail comes down completely:
Reverse Stop Tolerance: 1,000,000 ERPM
Reverse Stop Trigger: 1,500 ERPM
Reverse Stop ERPM Increment: 0.00000800
If the devs are interested, I'd be happy to develop this on top of the reworked reverse stop that's on main, before/after that's out of beta.