Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: luvs01/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
Motivation
session-idbut had differentthread-ids to collide on Cursor conversation state and remint/checkpoint continuity.Description
codexThreadConversationKey(headers)insrc/codex/lineage.tsto derive a per-thread HMAC identity from thesession-idandthread-idpair.src/server/responses/request-prepare.tsso Cursor ownership falls back to the thread-specific identity instead of the cohort-wide pool-affinity key.tests/codex-integration/codex-lineage-placement.test.tsthat asserts requests can share pool affinity while keeping distinct per-thread Cursor conversation identities.structure/providers/cursor.mdto document that a session-wide pool-affinity cohort must not be used as Cursor conversation ownership.Testing
bun run test -- tests/codex-integration/codex-lineage-placement.test.ts, which passed (17 tests, 0 failures).bun run typecheck,bun run structure:check, andbun run privacy:scan, all of which succeeded.bun run test; that run encountered unrelated environment-sensitive failures and timed/ran longer than expected so it was not completed here, but the focused tests and static checks for the modified areas are green.Codex Task