Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: luvs01/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Co-Authored-By: Epinephrine <luvs01@hanmail.net>
|
Fixed in 7266ca2 — see reply above. |
…e settles A fetch-based web-search stream keeps the account's quota-recovery probe while it is live (a later in-stream sidecar outcome may still clear the cooldown), but when the routed model answers without calling web_search no outcome ever consumes it. Hand the lease back through the stream's own completion/cancel tracker and the terminal no-body return, matching the release ownership executeResponsesRunTurn already uses. Co-Authored-By: Epinephrine <luvs01@hanmail.net>
The streamed-sidecar probe test only covered web-search completion; add the cancellation path (tracked stream cancel settles the lease) and the media-bridge stream, which shares the same ownership handoff. Co-Authored-By: Epinephrine <luvs01@hanmail.net>
|
이관됨: lidge-jun#6047 |
|
동일 수정이 상류 저장소에 제출되어 이 포크 PR의 목적은 달성됐습니다. |
Motivation
executeResponsesSidecarsreturns a pre-dispatchResponse(for example on malformed tool-result input) before therunTurncleanup runs.Description
sidecarState.openAiSidecar?.releaseProbeLease?.()before returning whenexecuteResponsesSidecarsreturns aResponseto ensure any acquired probe lease is released immediately. (src/server/responses/core.ts).prepareResponsesSidecarAuthto simulate a held probe lease and asserts a pre-dispatch 400 response releases the probe and does not dispatch the adapter. (tests/responses/responses-run-turn-web-search.test.ts).Testing
bun test tests/responses/responses-run-turn-web-search.test.ts --timeout 30000which passed (16 tests, 0 failures).bun run typecheck(passed),bun run structure:check(passed), andbun run privacy:scan(passed).bun run test:changedcould not be executed in this checkout due to a missing comparison ref (dev/origin/dev/upstream/dev), so focused regression coverage was used instead.Codex Task