Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: luvs01/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Co-Authored-By: Epinephrine <luvs01@hanmail.net>
|
이관됨: lidge-jun#5966 |
|
동일 수정이 상류 저장소에 제출되어 이 포크 PR의 목적은 달성됐습니다. 상류 심사 결과에 따라 닫힌 상태를 유지하거나 필요시 재오픈합니다. |
Motivation
Description
linkListenerOwnsTargetpredicate insrc/server/index/link-listener.tsto express when a listener actually owns a concrete listening socket (state === "listening" && port !== null).src/server/index/optional-listeners.tssosupervisor.start()runs only when the listener ownership predicate is true while preserving thesupervisorStopshutdown hook for later registration.tests/server/link-listener-lifecycle.test.tsto cover failed/off/listening ownership states.structure/remote-link.mdso the design intent is explicit: automatic startup must not start tunnels when the listener failed to bind.Testing
bun run typecheckwhich completed successfully.bun run structure:checkandbun run privacy:scanwhich completed successfully, andgit diff --checkreturned clean.bun test tests/server/link-listener-lifecycle.test.tsbut the environment-provided Bun (v1.2.14) fails importing anode:zlibsymbol used by the repository; the project requires Bun v1.4.0 so the focused test could not complete in this sandbox (the change adds a lightweight assertion that exercises the new predicate).Codex Task