Repository navigation
node_key: private-only key store; Windows keys in Credential Manager only (#19) - #22
Merged
Merged
Conversation
…tial Manager only (#19) Every KeyStore keeps the ML-DSA-87 seed, and in pq_hybrid the RSA-PSS key as PKCS #1, at most 2,429 bytes, inside Credential Manager's 2,560; the public keys are derived again on load. A key kept in 0.7.0's key-file form is refused KeptInTheKeyFileForm, which says to create the identity again. The seed form moves to node_key/seed_form.rs; key files (node_key/key_file.rs) are unix only, and on Windows NodeKey::save, load and load_or_create refuse NoKeyFile, naming the store to use. A windows-latest CI job round-trips both profiles through the real Credential Manager. Tests: the kept size at the worst RSA size, and the 0.7.0 form refused; both failed first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ut bytes are wiped (#19) From Fable's review: KeyringStore on Windows builds its Credential Manager credential with persistence=local (CRED_PERSIST_LOCAL_MACHINE); the store's default, Enterprise, roams with a domain profile. A key's laid-out bytes are Zeroizing, allocated once at full size so no growth leaves a copy. The kept size at most is 2,431 bytes (STORE_MAGIC is 27). FFI docs and its key-file test say unix only; the Windows test clears a stale file first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…a mapping Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for CI only (the windows-latest Credential Manager job). Not for merge here: master moves by the usual push after review.
Purpose (security): a node's identity key at rest on Windows is readable by its owner only. Register row: Identity keys protected at rest.
🤖 Generated with Claude Code