Repository navigation
Conversation
- a restarted distributor answers a lost epoch unknown_epoch (keys) - off after preferred is ignored, as after required (keyring) - a quiet re-pull picks up required from the distributor's latest word (keyring) - a clear event under a required group is counted, not just refused (client_group) All four were coverage gaps: the behaviour was already implemented.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gap-map of the §10 "Tests, red first" list against the suite at v14.8.1: four items were untested even though the behaviour existed.
unknown_epoch(epochs are memory-only)offafterpreferredis ignored, as afterrequired(policy is monotonic per node run)requiredfrom the distributor's latest word (only the downgrade tooffis blocked)requiredgroup is counted (diagnostics bound), not just refusedAll four went green immediately; this PR is coverage only, no production change.
Refs macula#91 for the one remaining gap (the distributor's default realm-membership path).