Repository navigation
Conversation
…r's default membership (macula#91) (red)
…embership (macula#91) realm_membership/2 answers the realm slot through an optional lookup fun, defaulting to the pool lookup exactly as before. The default path (a realm tombstone withdrawing a member's endorsement) was untestable without it: the only seam the design named, and the last uncovered item of DESIGN_E2E_SEALED_PUBSUB.md §10.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The one remaining test gap from the §10 gap-map: the distributor's DEFAULT membership path (realm slot endorsement, tombstone → withdrawn →
not_a_member) had no seam and no test.test: ... (red): a realm-endorsed member is admitted; a realm-tombstoned member is refused. Red without the seam (the default path hits the real pool machinery and crashes).seal: ...:lookupoption onmacula_group_keys:options(), answering whatmacula:find_records/2would (decoded records), defaulting to the pool lookup. The injection mirrors the SDK'sprovider_io/dial_ioseam pattern.Verified: full
macula_group_keys+keyring+client_group+ new module suites, 55 tests, all green.Closes macula#91.